CSE2410 Fall 2014 the Passive Aggressors

Time stamp finally fixed we can all die happy now

I noticed a particular bit of ambiguity on where one of the feature requests is. As such, here is the other possibility

Adds a checkbox to toggle between ascii and unicode text in follow tcp stream, as well as a check box which, when checked, causes wireshark to generate an accompanying rtf file whenever a new capture is saved

I fixed the newline bug, but not as expected. The way that Wireshark parses the Packet Comments is actually in the epan/dissectors folder. Fixing it in QT will break it in GTK. Fixing this so that it displays correctly in both GTK and QT will require a huge refactoring of Wireshark's core code. So, what I did was treat a newline as a sentence. This way, every newline is a period with 2 spaces. This way, packet comments are still organized neatly and without chopping off the full comment.

Ok, I should explain the last commit. I added a QAction, or a tick mark, under the Edit menu. So If you click on Hide Main Window During Cpature under the Edit menu, it will add a checkbox. This commit I updated \\ui\qt\main_window_slots.cpp to hide the main Window if this option is checked. Looks like Bug 4291 is fixed! However,..I haven't tested it. So if someone could verify that this works I would think you're the best person ever.

Use FreeRADIUS's warning pragma controls to suppress Apple complaints.

Apple would really rather that you use their Shiny Happy Frameworks
rather than those crufty old cross-platform APIs. We are a
cross-platform program, and will use platform-specific APIs only if...

packet-mausb.c: proto-reg-handoff() fixes

- proto_reg_handoff...():
Fix handling of tcp port pref change;
Rename 'gPORT_PREF' to 'mausb_tcp_port_pref';
Do 'dissector_add_uint("llc.mausb_pid",..)' only once;

Change-Id: Ic4498560f61d0ce95f8109c3a1bb3c407221269b...

E.212: update list to Operational Bulletin No. 1058 (15.VIII.2014)

Change-Id: I79d12c4699df01f3435fae5342aa5ec295316959
Reviewed-on: https://code.wireshark.org/review/3874
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>...

Exclude MA USB TransferAck's from USB conversation

the usb_trans_info struct only understands Requests & Responses.
TransferAcks are currently treated as responses, which throws off
the Request/Response pairing & dissection.

This patch fixes tracking in the case when a TransferAck & TransferReq...

Add custom_layer_chm.xsl to UNKNOWN (fix checklicence)

Change-Id: I4c336f21f721443e83eca7b9bf8d7a6138b367f4
Reviewed-on: https://code.wireshark.org/review/3827
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>

Extcap: restore compatibility with GLib 2.16.0

While we are at it, fix what seem to be a memory leak in extcaps_init_initerfaces()

Change-Id: I1bb9a1b44d16f986eedd192b15cce84c5881a917
Reviewed-on: https://code.wireshark.org/review/3820
Reviewed-by: Roland Knall <rknall@gmail.com>...

USB: get rid of the remaining proto_tree_add_text instances

Change-Id: I6acaa32745e32ec5728874549e420468499d9b24
Reviewed-on: https://code.wireshark.org/review/3860
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>

Added Authentication-Method and afew other AVPs that appear in the SIP-Auth-Data-Item grouped AVP.

Change-Id: Ie90ec71d8d574d38f32a5ff3de6ad5433b9e5e9f
Reviewed-on: https://code.wireshark.org/review/3823
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Non-standard USB control requests now handled in own function

Change-Id: Icf56f3f5899d17908dac4783d2b3e30373186eba
Reviewed-on: https://code.wireshark.org/review/3850
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>...

added try_dissect_linux_usb_pseudo_header_ext helper function

Change-Id: I05b0adaef2b979432e293bc26e2a122a0d3551fc
Reviewed-on: https://code.wireshark.org/review/3848
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>...

The remaining build systems didn't know about the change of the
capture chapter from xml to asciidoc either.

Change-Id: Ia48d4e0e4b445aedabd29a8483bcc19f12c13b20
Reviewed-on: https://code.wireshark.org/review/3857
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

Added missing name to AUTHORS file.

Change-Id: I674c60a39e9e85e441fdb28c14a0845e34115b53
Reviewed-on: https://code.wireshark.org/review/3853
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Skinny Dissector:

Source Fix: Trailing Whitespace (Reported by Graham Bloice).
Dissection Fix: ProtocolVer needed to be split up into two fields to display the protocol version correct during device registration
Segfault Fix: Null Pointer Check required after returning from tvb_memdup, before calling strlen (Reported by Evan Huus)...

The timezone for generating the NEWS file timestamp was changed to UTC

Change-Id: I77187bf4738a20bcebd899e2a01afd6077ae7e6c
Reviewed-on: https://code.wireshark.org/review/3845
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

WSUG: Convert the "Capturing" chapter to AsciiDoc.

Leave most of the content intact for now. Add a section on markup
conventions to README.txt. Remove the .mediaobject border.

Change-Id: I06cfd482a4c8ea63c90b9f59fcdf2afaf636a4a2
Reviewed-on: https://code.wireshark.org/review/3821...

reformat dissect_usb_setup_response()
make sure it can handle usb_conv_info==NULL

Change-Id: I5f53b26fd6fe22471906b07b5dad8f4c07dffa55
Reviewed-on: https://code.wireshark.org/review/3843
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>

More README.cmake updates.

Change-Id: I1c7e51ee397171af0703878e509665c8119b37ba
Reviewed-on: https://code.wireshark.org/review/3841
Reviewed-by: Gerald Combs <gerald@wireshark.org>

checkhf.pl: (Trivial) fix two typos

Change-Id: I2a63127dcf819d671a4c814dcbd82b2dca5022d3
Reviewed-on: https://code.wireshark.org/review/3838
Reviewed-by: Bill Meier <wmeier@newsguy.com>

BPG : issue with BGP AS path heuristic (AS_CONFED_SET)

Add also a expert info when unable determine ASN length (2 or 4 bytes)

Bug: 10399
Change-Id: I24978e29e24f38c2e01e4b953a5a51496f0cf5a6
Reviewed-on: https://code.wireshark.org/review/3831
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>...

Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I4a2ba6902acc0cbd224a8926eeb7bd0b62b4d29e
Reviewed-on: https://code.wireshark.org/review/3825
Reviewed-by: Evan Huus <eapache@gmail.com>

RPKI RTR: Wrong decoding of RPKI RTR End of Data PDU

The decoding of the End of Data PDU ignores the Serial Number, i.e., the last 32 bit of this PDU. Instead of that the current dissector implementation starts to decode a new RTR PDU.

Details of packet format see http://tools.ietf.org/html/rfc6810#section-5.8...

remove trans_info parameter from dissect_usb_endpoint_descriptor()
(remove it in the call from mausb as well)

add NULL checks for usb_conv_info, usb_trans_info

Change-Id: I95d52b85e3fa0d42b6a20047053259aaca8754fe
Reviewed-on: https://code.wireshark.org/review/3784...

an endpoint_descriptor may only be sent from a USB device to the host
as part of a GET DESCRIPTOR Response

therefore, pinfo->destport==NO_ENDPOINT is always true for valid USB
packets and we can remove the else branch

Change-Id: I2163e3000cafa27113ee0e6173fd69b7ef17b812...

TRILL ISIS: SubTLVs of Router Capability TLV are valid for MT-Capability TLV as well

Change-Id: Idf466c021b1b188d9c6d55ba73a25257ba352412
Reviewed-on: https://code.wireshark.org/review/3803
Petri-Dish: Evan Huus <eapache@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>...

Remove obsolete comments regarding the shell version of make-dissector-reg

Change-Id: I93470e8c6e9afd6c1ebf735eb13141586964be0e
Reviewed-on: https://code.wireshark.org/review/3818
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>

Try to get HTML Help to render SVG.

Add a custom stylesheet that inserts

<meta http-equiv="X-UA-Compatible" content="IE=9" >

at the top of our HTML Help output. This should convince the
WebBrowser control to draw our new SVG images.

Change-Id: Iae491128195d3738951f3d19e2f82dd3fc73d1d8...

[Automatic manuf, services and enterprise-numbers update for 2014-08-24]

Change-Id: Ibe3e8e23f8ae5a136c1acb0eda4cfe03928616d2
Reviewed-on: https://code.wireshark.org/review/3811
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Clean up capinfos output.

Make sure there's always a space between a number and "[TGMK]bytes",
"[TGMK]bits", and "[TGMK]packets".

Change-Id: I710385303e451e9aea6fc9bbea562f59ca0d22c9
Reviewed-on: https://code.wireshark.org/review/3810
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Strengthen the heuristics for pcap subtypes.

When trying to guess what type of capture a file is, look for as many
bogosities (caplen > len, microseconds >= 10^6/nanoseconds >= 10^9,
too-high caplen, too-high original len, caplen > snapshort length), to
increase the chances of guessing correctly....

Modify includes of config.h so that out-of-tree builds, i.e. CMake
don't pick up the in-tree copy.

Change-Id: I7ec473876cdba1a025c52362d7f6adc62d24ce71
Reviewed-on: https://code.wireshark.org/review/3798
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>...

Convert admon graphics to SVG.

Use a common set of SVG files for AsciiDoc / DocBook admonition
graphics. Put them in a common directory. According to
http://caniuse.com/svg all common browsers have had SVG support for
a while now.

The graphics themselves were created with Inkscape. If you would like...

CMake: More a2x / asciidoc fixes.

Create graphics directories and copy files into them similar
to Autotools and Nmake. Adjust some xsltproc arguments. Fix the
--asciidoc-opts flag.

Note: Admon graphics are broken pending change 3206.

Change-Id: I94d498de36150a7cb4ffd080581523300b222bd4...

WSUG: Convert the "User Interface" chapter to AsciiDoc.

Add the "asciidoc.conf" compatibility configuration file from
Asciidoctor. Although we don't use Asciidoctor it gives us macros that
keep us from losing some useful DocBook elements. Update various CMake...

Update the SCTP PPIDs.

Change-Id: I0b34e544d4332f2b5d8dcc287861636db86ac1b9
Reviewed-on: https://code.wireshark.org/review/3801
Petri-Dish: Michael Tüxen <tuexen@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Tüxen <tuexen@wireshark.org>

Cope with MIT being line wrapped when compiling with kerberos

The line "Massachusetts Institute of Technology" now appears
across two lines in the header file.

Change-Id: I618b520d6c15f51180b47d93c75e29a6f43b868b
Reviewed-on: https://code.wireshark.org/review/3790...

Replace a couple of implementations of unpack_digits() with tvb_bcd_dig_to_wmem_packet_str().

Change-Id: Ic9e740345fb3a748f6df4f624441bb947bbd9429
Reviewed-on: https://code.wireshark.org/review/3797
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Fix a comment typo: tvb_bcd_dig_to_wmem_packet_str() returns a WMEM-allocated
string, not an EP-allocated one.

Change-Id: I3918ed66429c588d4503d98e10dc460b099e550e
Reviewed-on: https://code.wireshark.org/review/3795
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>

TRILL ISIS: Implement TRILL Neighbor TLV (145)

Change-Id: I1b17b0ef26150fdc68b966f4837953f9832883cb
Reviewed-on: https://code.wireshark.org/review/3717
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>...

TRILL updates

Update Version info
Update Nickname IDs
Add new multicast MAC addresses

Change-Id: I72647b5f98a48267340d51df428602e1c77cb206
Reviewed-on: https://code.wireshark.org/review/3714
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>...

TGPPRx: Add AF-Signalling-Protocol AVP dissection support

The AVP is defined in 3GPP TS 29.214, Table 5.3.1: Rx specific Diameter AVPs.

Change-Id: Ib0a525f97206ff61bb0d390df81e3d6ebbef59bb
Reviewed-on: https://code.wireshark.org/review/3791
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Regenerate the X11 dissector with the latest mesa, xcb, and process-x11-xcb.pl

Change-Id: Ie05f9b780011b215ca3ad3293b3daefbcbee68ce
Reviewed-on: https://code.wireshark.org/review/3789
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>

plugins.c: cleanup plugins_scan_dir()

add_plugin() no longer returns ENOMEM. Remove code in
 plugins_scan_dir() which printed an error message
 if ENOMEM returned by add_plugin().

Fix comment re add_plugin() return values.

Change-Id: Id5170c28e2a55884d41ceebc4e07f16389b75a2a...

Fix CMake checks of PCap functions, along with AirPCap

Change-Id: If55498167d5e357258841f2194962749c0dfc81e
Reviewed-on: https://code.wireshark.org/review/3787
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>...

Decode User-Name as an IMSI in S13/S13' and S7a/S7d.

Also move the application ID macros into the diameter header file.

Change-Id: Iaca5707c8476d81f50ecdb3aab76be293b5ccfe7
Reviewed-on: https://code.wireshark.org/review/3786
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>

remove trans_info parameter from dissect_usb_interface_assn_descriptor()

Change-Id: I9069835a824abcb004b05659a20b00a783a28ed6
Reviewed-on: https://code.wireshark.org/review/3782
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>