Activity

From 03/01/2013 to 03/30/2013

03/30/2013

04:52 PM Revision 840a29fc (main_repo): buffer: change output of Buffer.prototype.toJSON()
Expand the JSON representation of Buffer to include type information
so that it can be deserialized in JSON.parse() w...
David Braun
04:35 PM Revision 55ea7ccf (main_repo): repl: use more readable RegExp syntax for spaces
This is just a cosmetic change really, nothing major. Nathan Rajlich
04:10 PM Revision 085f9d63 (main_repo): repl: isSyntaxError() catches "strict mode" errors
Closes #5178. Nathan Rajlich
08:49 PM Revision 9b8dd395 (main_repo): dtrace: check if _handle property is set
Check that _handle is an object before trying to read its `fd`
property, avoids bogus values.
Ben Noordhuis
08:30 PM Revision aa5da485 (main_repo): dtrace: actually use the _handle.fd value
When using the DTrace/systemtap subsystems it would be helpful to
actually have an fd associated with the requests an...
Timothy J Fontaine
08:04 PM Revision 76340696 (main_repo): dtrace: pass more arguments to probes
OSX and other DTrace implementations don't support dereferencing
structs in probes. To accomodate that pass members f...
Dave Pacheco
08:04 PM Revision fe7440ce (main_repo): build: allow building with dtrace on osx
Dave Pacheco

03/29/2013

07:53 PM Revision 2093e7d9 (main_repo): lint: add isolate, remove semicolon
Trevor Norris
12:39 PM Revision 7af075ee (main_repo): crypto: Pass options to ctor calls
isaacs
11:13 AM Revision 3f091c72 (main_repo): src: fix Persistent<> deprecation warning
Pass the Isolate to Persistent<Function>::New(). Fixes the following
warning:
../../src/node.cc: In function ‘v8::...
Ben Noordhuis
11:10 AM Revision 87f9ece3 (main_repo): deps: upgrade libuv to c43e851
Ben Noordhuis
09:53 AM Revision 74ef9490 (main_repo): zlib: allow passing options to convenience methods
Kyle Robinson Young

03/28/2013

05:53 PM Revision 1d17ced2 (main_repo): blog: v0.11.0 release
isaacs
05:50 PM Revision 46da8c2d (main_repo): Now working on 0.11.1
isaacs
05:50 PM Revision caacc19e (main_repo): Merge branch 'v0.11.0-release'
isaacs
05:39 PM Revision f1fa7566 (main_repo): blog: Update linux binary tarball shasums
I just accidentally the binary release. isaacs
04:53 PM Revision bce38b3d (main_repo): 2013.03.28, Version 0.11.0 (Unstable)
* V8: update to 3.17.13
* os: use %SystemRoot% or %windir% in os.tmpdir() (Suwon Chae)
* util: fix util.inspect() l...
isaacs
04:19 PM Revision 9100dd4b (main_repo): lint
Fixes lint errors introduced in 120e5a24df76deb5019abec9744ace94f0f3746a isaacs
04:11 PM Revision 97c70a66 (main_repo): Merge remote-tracking branch 'ry/v0.10'
Conflicts:
src/node.cc
src/node_version.h
isaacs
04:06 PM Revision 708e8589 (main_repo): blog: Post about v0.10.2
isaacs
04:06 PM Revision 61d254eb (main_repo): Node working on 0.10.3
isaacs
04:05 PM Revision 8106dc36 (main_repo): Merge branch 'v0.10.2-release' into v0.10
isaacs
03:12 PM Revision 902d6cb6 (main_repo): src: tie process.versions.uv to uv_version_string()
Ben Noordhuis
03:07 PM Revision 1e0de9c4 (main_repo): 2013.03.28, Version 0.10.2 (Stable)
* npm: Upgrade to 1.2.15
* uv: Upgrade to 0.10.3
* tls: handle SSL_ERROR_ZERO_RETURN (Fedor Indutny)
* tls: handle...
isaacs
03:05 PM Revision 1b5ec033 (main_repo): deps: upgrade libuv to v0.10.3
Bert Belder
02:35 PM Revision dea0634f (main_repo): npm: Upgrade to v1.2.15
isaacs
01:59 PM Revision 4580be08 (main_repo): tls: handle SSL_ERROR_ZERO_RETURN
see #5004 Fedor Indutny
01:40 PM Revision 39058bef (main_repo): setTimeout: do not calculate Timeout._when property
Dramatically improves Timer performance. wicked
01:27 PM Revision 929e4d9c (main_repo): stream: Emit readable on ended streams via read(0)
cc: @mjijackson isaacs
01:27 PM Revision eafa9026 (main_repo): stream: Handle late 'readable' event listeners
In cases where a stream may have data added to the read queue before the
user adds a 'readable' event, there is never...
isaacs
12:53 PM Revision 5ae26f37 (main_repo): doc: Add 'don't ignore errors' section to domain
Also, an example program of using cluster and domain to handle errors
safely, with zero downtime, using process isola...
isaacs
11:50 AM Revision 024a8b0c (main_repo): doc: debugger, dns, http: fix grammar
Benjamin Ruston
11:44 AM Revision 120e5a24 (main_repo): os: use %SystemRoot% or %windir% in os.tmpdir()
On Windows, respect the SystemRoot and windir environment variables,
don't default to c:\windows\temp.
Suwon Chae
08:50 AM Revision 1f557047 (main_repo): util: fix util.inspect() line width calculation
Have the formatter filter out vt100 color codes when calculating the
line width. Stops it from unnecessarily splittin...
Marcin Kostrzewa

03/27/2013

07:28 PM Revision 982877ec (main_repo): deps: upgrade libuv to 7514149
Ben Noordhuis
12:47 PM Revision 61935bc1 (main_repo): test: Accept either kind of NaN
A llvm/clang bug on Darwin ia32 makes these tests fail 100% of
the time. Since no one really seems to mind overly mu...
isaacs
08:26 AM Revision ae86fa84 (main_repo): tls: handle errors before calling C++ methods
Calling `this.pair.encrypted._internallyPendingBytes()` before
handling/resetting error will result in assertion fail...
Fedor Indutny
07:37 AM Revision 372911ff (main_repo): doc: addon: fix grammar
Benjamin Ruston
03:41 AM Revision 28c6e42e (main_repo): openssl: disable HEARTBEAT TLS extension
Microsoft's IIS doesn't support it, and is not replying with ServerHello
after receiving ClientHello which contains i...
Fedor Indutny
12:26 AM Revision f0b68892 (main_repo): domain: fix domain callback from MakeCallback
Since _tickCallback and _tickDomainCallback were both called from
MakeCallback, it was possible for a callback to be ...
Trevor Norris

03/26/2013

06:23 PM Revision 85489209 (main_repo): openssl: make sed tool configurable
Those poor sods on systems where /usr/bin/sed is a BSD sed can now do
`make -C deps/openssl/asm SED=gsed`.
Ben Noordhuis
01:17 PM Revision 2eb84784 (main_repo): test: Use 'close' event in simple/test-repl-timeout-throw
isaacs
12:53 PM Revision ccda6bb3 (main_repo): buffer: remove _charsWritten
_charsWritten is an internal property that was constantly written to,
but never read from. So it has been removed.
R...
Trevor Norris
11:34 AM Revision a80a132b (main_repo): doc: child_process: document 'error' event
Fixes #5130. Ben Noordhuis
11:09 AM Revision 0e08e147 (main_repo): doc: fix formatting in tty.markdown
Fixes #5135. Ben Noordhuis
08:37 PM Revision d2057616 (main_repo): tls: expose SSL_CTX_set_timeout via tls.createServer
Add the `sessionTimeout` integral value to the list of options
recognized by `tls.createServer`.
This option will be...
Manav Rathi

03/25/2013

07:27 PM Revision 1a65154d (main_repo): Merge remote-tracking branch 'origin/v0.10'
Conflicts:
deps/v8/src/objects-inl.h
deps/v8/src/objects.h
src/node_crypto.cc
Ben Noordhuis
07:21 PM Revision fb6dd0c0 (main_repo): test: test name is the last elem, not second
When a test requires node to have parameters passed (--expose-gc) the
test name will be the last element in the comma...
Timothy J Fontaine
06:07 PM Revision 9352c198 (main_repo): child_process: don't emit same handle twice
It's possible to read multiple messages off the parent/child channel.
When that happens, make sure that recvHandle is...
Ben Noordhuis
01:42 PM Revision cfd0dca9 (main_repo): crypto: make getCiphers() return non-SSL ciphers
Commit f53441a added crypto.getCiphers() as a function that returns the
names of SSL ciphers.
Commit 14a6c4e then ad...
Ben Noordhuis
08:54 AM Revision 488b74d6 (main_repo): doc: mention `process.*.isTTY` under `process`
Mathias Bynens
08:23 AM Revision 44843a60 (main_repo): child_process: fix sending utf-8 to child process
In process#send() and child_process.ChildProcess#send(), use 'utf8' as
the encoding instead of 'ascii' because 'ascii...
Ben Noordhuis
08:16 AM Revision 05bd6b7b (main_repo): bench: add child process read perf benchmark
Ben Noordhuis

03/24/2013

05:53 PM Revision 690a8cce (main_repo): deps: fix openssl build on windows
Commit 8632af3 ("tools: update gyp to r1601") broke the Windows build.
Older versions of GYP link to kernel32.lib, u...
Ben Noordhuis
05:23 PM Revision c0d50010 (main_repo): stream: Fix early end in Writables on zero-length writes
Doing this causes problems:
z.write(Buffer(0));
z.end();
Fix by not ending Writable streams while they're s...
isaacs
10:03 AM Revision 8632af38 (main_repo): tools: update gyp to r1601
Among other things, this should make it easier for people to build
node.js on openbsd.
Ben Noordhuis
08:28 AM Revision 329b5388 (main_repo): doc: update CONTRIBUTING.md
* Latest stable is v0.10 now.
* Add example of what the first line of the commit log should look like.
Ben Noordhuis
09:46 PM Revision 9fae4dc1 (main_repo): timer: fix off-by-one ms error
Fix #5103 Alexey Kupershtokh

03/23/2013

02:32 PM Revision 51f128d6 (main_repo): fs: uv_[fl]stat now reports subsecond resolution
While libuv supports reporting subsecond stat resolution across
platforms, to actually get that resolution your platf...
Timothy J Fontaine
02:17 PM Revision 648a0726 (main_repo): deps: upgrade libuv to eca008a
Ben Noordhuis
01:05 PM Revision 9430ca68 (main_repo): tls: remove harmful unnecessary bounds checking
The EncIn, EncOut, ClearIn & ClearOut functions are victims of some code
copy + pasting. A common line copied to all ...
Marcel Laverdet
01:04 PM Revision 15269090 (main_repo): tls: remove harmful unnecessary bounds checking
The EncIn, EncOut, ClearIn & ClearOut functions are victims of some code
copy + pasting. A common line copied to all ...
Marcel Laverdet
12:14 PM Revision 14417fdb (main_repo): v8: Unify kMaxArguments with number of bits used to encode it.
Increase the number of bits by 1 by making Flags unsigned.
BUG=chromium:211741
Review URL: https://chromiumcoderevi...
verwaest@chromium.org
10:50 AM Revision 628bd81a (main_repo): crypto: check randomBytes() size argument
Throw a TypeError if size > 0x3fffffff. Avoids the following V8 fatal
error:
FATAL ERROR: v8::Object::SetIndexedPr...
Ben Noordhuis
10:38 AM Revision 132c77e9 (main_repo): doc: document that stdio is usually blocking
Ben Noordhuis

03/22/2013

08:49 PM Revision c3aae9cf (main_repo): stream: Fix stall in Transform under very specific conditions
The stall is exposed in the test, though the test itself asserts before
it stalls.
The test is constructed to replic...
Gil Pedersen

03/21/2013

02:09 PM Revision bfd16de1 (main_repo): timers: handle signed int32 overflow in enroll()
Before this patch calling `socket.setTimeout(0xffffffff)` will result in
signed int32 overflow in C++ which resulted ...
Fedor Indutny
01:54 PM Revision f7ebb4d8 (main_repo): doc: update that ascii write doesn't convert null
Since WriteBuffer has been replaced with WriteOneByte, writing ascii
will no longer automatically convert 0x0 to 0x20...
Trevor Norris
01:52 PM Revision 2f88272b (main_repo): Merge remote-tracking branch 'ry/v0.10' into master
Conflicts:
src/node.cc
src/node_version.h
isaacs
01:15 PM Revision f150d569 (main_repo): src: write ascii strings using WriteOneByte
WriteAscii will be deprecated soon from v8, and performance has
regressed. The v8 team recommended using WriteOneByte...
Trevor Norris
12:14 PM Revision 92cc1878 (main_repo): blog: Post for v0.10.1
isaacs
12:14 PM Revision 9d3a09f9 (main_repo): Now working on v0.10.2
isaacs
12:13 PM Revision 41405f47 (main_repo): Merge branch 'v0.10.1-release' into v0.10
isaacs
09:59 AM Revision e47a3e3f (main_repo): deps: upgrade libuv to 9b61939
Ben Noordhuis
09:15 PM Revision c274d164 (main_repo): 2013.03.21, Version 0.10.1 (Stable)
* npm: upgrade to 1.2.15
* crypto: Improve performance of non-stream APIs (Fedor Indutny)
* tls: always reset this....
isaacs
08:49 PM Revision 3dd7938c (main_repo): npm: upgrade to 1.2.15
isaacs

03/20/2013

07:49 PM Revision 855caa82 (main_repo): crypto: initialize transform lazily
Fedor Indutny
07:14 PM Revision 008ab12b (main_repo): tls: Prevent hang in readStart
This is not a great fix, and it's a bug that's very tricky to reproduce.
Occasionally, while downloading a file, esp...
isaacs
03:25 PM Revision 31314b69 (main_repo): bench: compare binaries equal times
The benchmark compare would drop the last run of the binary pairs. So
when they were only run once an error would ari...
Trevor Norris
12:16 PM Revision 3dac4213 (main_repo): bench: add dgram send/recv benchmark
Ben Noordhuis
09:58 AM Revision 34e22b8e (main_repo): tls: always reset this.ssl.error after handling
Otherwise assertion may happen:
src/node_crypto.cc:962: void node::crypto::Connection::ClearError():
Asserti...
Fedor Indutny
04:26 AM Revision 40b1c9a6 (main_repo): v8: unbreak build on smartos after 831af97df211f04
Fedor Indutny
08:56 PM Revision ad819bcc (main_repo): src: bump NODE_MODULE_VERSION after abi change
Ben Noordhuis
08:53 PM Revision dc29d649 (main_repo): test: fix up weakref.cc after v8 api change
Ben Noordhuis
08:37 PM Revision 25eaacad (main_repo): fs: make write/appendFileSync correctly set file mode
Raymond Feng
08:11 PM Revision 88217ec2 (main_repo): dtrace: fix generation of v8 constants on freebsd
Every constant is certainly 4 bytes now, but freebsd's objdump utility
prints out odd byte sequences (5-bytes, 6-byte...
Fedor Indutny
08:11 PM Revision 3cb5bf1c (main_repo): dtrace: fix style in ustack helper
Fedor Indutny
08:11 PM Revision f65e14ed (main_repo): src: pass Isolate to all applicable api
Update the api to pass node_isolate to all supported methods.
Much thanks to Ben Noordhuis and his work in 51f6e6a.
Trevor Norris
08:11 PM Revision d9036a5d (main_repo): dtrace: More style
Continuation lines should be indented with 4 spaces, not a tab. isaacs
08:11 PM Revision 425163e0 (main_repo): dtrace: Make D style more D-ish
isaacs
08:11 PM Revision 3375bd8d (main_repo): dtrace: x64 ustack helper
Fedor Indutny
08:11 PM Revision da4d79ac (main_repo): docs: show how to use Isolate
Part of the 3.17 update is to pass the isolate as an argument. The addon
docs have been updated with this usage.
Trevor Norris
08:11 PM Revision 831af97d (main_repo): v8: revert dtrace fix from 3.14 downgrade
Revert "v8: fix postmortem and dtrace helper build"
This reverts commit aa985392777dbe6159ce4ca56ae79d1039e43ec7.
Trevor Norris
08:11 PM Revision 8bffa333 (main_repo): v8: loosen artificial mmap constraint
Fixes #4010. Bryan Cantrill
08:11 PM Revision 0bba5902 (main_repo): bindings: update api
All compile time warnings about using deprecated APIs have been
suppressed by updating node's API. Though there are s...
Trevor Norris
08:11 PM Revision 06bec0e0 (main_repo): v8: remove optimization switches
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi,
they are set globally in $(TOPLEVEL)/common.gypi.
Trevor Norris
08:11 PM Revision 83261e78 (main_repo): deps: update v8 to 3.17.13
Trevor Norris

03/19/2013

07:34 PM Revision 2f4a62c5 (main_repo): doc: fix streams2 SimpleProtocol example
A non-existing variable `b` was used to queue data for reading. Iskren Ivov Chernev
07:16 PM Revision bf83251e (main_repo): windows: enable watching signals with process.on('SIGXYZ')
This reverts commit ea1cba6246a8b1784e22d076139b9244a9ff42f8.
The offending commit was intended to land on the v0.8 ...
Bert Belder
03:07 PM Revision 8019800c (main_repo): Update .mailmap and AUTHORS
Bert Belder
12:38 PM Revision a05f973f (main_repo): test: Misc Windows unit test fixes
Fixes #5071, #5073.
* Normalize capitalization of drive letter
* Fix `exit()` typo in failure path
* Ignore symlink ...
Scott Blomquist

03/18/2013

09:41 AM Revision 808b7ada (main_repo): doc: fix broken links in blog footer
The blog lives at blog.nodejs.org while the main website lives at
nodejs.org. Ergo, use absolute URLs for links to th...
Ben Noordhuis

03/17/2013

12:19 PM Revision b5ddc0cf (main_repo): tls: write pending data of opposite side
Fix stucked CryptoStream behaviour, happening when one of the sides
locks-up in queued state.
fix #5023
Fedor Indutny
12:17 PM Revision 14a8fb8b (main_repo): tls: write pending data of opposite side
Fix stucked CryptoStream behaviour, happening when one of the sides
locks-up in queued state.
fix #5023
Fedor Indutny
08:45 AM Revision a0867e1c (main_repo): node: revert removal of MakeCallback
In 0168109 an implementation of MakeCallback was accidently removed. It
has been re-added.
Trevor Norris
08:45 AM Revision f217b5ed (main_repo): doc: fix typo in crypto docs
JeongHoon Byun

03/16/2013

06:52 PM Revision 852444a7 (main_repo): doc: https: Fix the link to tls.connect
Yi EungJun
06:32 PM Revision f5a337e0 (main_repo): deps: upgrade libuv to b45a74f
Ben Noordhuis
06:22 PM Revision 2b5bc8e0 (main_repo): install: don't install man page twice
Looks like a merge conflict in 77ed12f left in the old, unconditional
install rule. Remove it, the new and improved r...
Ben Noordhuis
10:18 PM Revision 94284e7d (main_repo): readline: handle wide characters properly
Handle wide characters (such as あ, 谢, 고) as two column wide to make
cursor move properly.
Closes #555.
Closes #4994.
Nao Iizuka

03/15/2013

08:31 PM Revision 4432dc81 (main_repo): v8: move 32 bit heap hint on sunos
Setting the V8 heap at or near 0x20000000 on 32bit sunos only allows
512 MB of heap space, instead on sunos move this...
Timothy J Fontaine

03/14/2013

07:43 PM Revision 14947b6c (main_repo): stream: Return self from readable.wrap
Also, set paused=false *before* calling resume(). Otherwise,
there's an edge case where an immediately-emitted chunk...
isaacs
07:18 PM Revision 3537b57f (main_repo): test: No need for kicking in streams2 test
This was necessary when we weren't auto-starting when a 'readable'
listener is added.
isaacs
07:13 PM Revision e8f80bf4 (main_repo): stream: Never call decoder.end() multiple times
Updated version that does what it says without assigning state.decoder. Gil Pedersen
07:03 PM Revision c0721bcd (main_repo): repl: Use a domain to catch async errors safely
Fix #2031 isaacs
04:49 PM Revision 5eacdd4b (main_repo): repl: emit 'reset' event when context is reset
Closes #1183. Sami Samhuri
04:06 PM Revision 1f53cfde (main_repo): doc: don't mark fs callbacks as optional
Refs #5005, #5008 koichik
11:04 AM Revision d62cf59d (main_repo): http: Don't hot-path end() for large buffers
The benefits of the hot-path optimization below start to fall off when
the buffer size gets up near 128KB, because th...
isaacs
10:55 AM Revision ca5022b8 (main_repo): net: improve arbitrary tcp socket support
Consider this example:
// fd 3 is a bound tcp socket
var s = net.createServer(cb);
s.listen({ fd: 3 });
cons...
Ben Noordhuis
10:55 AM Revision e99dff46 (main_repo): deps: upgrade libuv to 7b66ea1
Ben Noordhuis
07:55 AM Revision 028c630e (main_repo): doc: change dgram to socket for properties of dgram.Socket
Fixes #4919. Adam Malcontenti-Wilson

03/13/2013

06:51 PM Revision 5e140b33 (main_repo): Revert "fs: Missing cb errors are deprecated, not a throw"
This reverts commits 6bd8b7e5405e1cdc9f56214f5f6b741806c32e5f
and fa05e8a2706e20a191942fe2b2273481605a1f14.
isaacs
06:51 PM Revision 59178286 (main_repo): Merge remote-tracking branch 'ry/v0.10'
Conflicts:
src/node_version.h
isaacs
06:48 PM Revision 6399839c (main_repo): Revert "stream: Never call decoder.end() multiple times"
This reverts commit 615d809ac684a7d2cc7ee5e1aa58f0a921b529a0. isaacs
06:34 PM Revision fa05e8a2 (main_repo): doc: implicit fs callbacks don't throw in v0.10
But they will in v0.12.
Re #5005.
Ben Noordhuis
06:34 PM Revision 6bd8b7e5 (main_repo): fs: Missing cb errors are deprecated, not a throw
Commit a804347 makes fs function rethrow errors when the callback is
omitted. While the right thing to do, it's a cha...
isaacs
06:27 PM Revision 7b7235a2 (main_repo): doc: add note on process.title max length
Fixes #5006. Ben Noordhuis
06:20 PM Revision 615d809a (main_repo): stream: Never call decoder.end() multiple times
Fixes decoder.end() being called on every push(null). As the tls module
does this, corrupt stream data could potentia...
Gil Pedersen
02:26 PM Revision 110cacd1 (main_repo): core: Move UNWRAP_NO_ABORT to handle_wrap.h
Otherwise it cannot be used in StreamWrap.
Forgot to include in last patch, broke the build.
isaacs
01:42 PM Revision 9af0085f (main_repo): doc: path.join() arguments must be strings
In v0.8, non-string arguments were ignored. v0.10 throws an exception. Ben Noordhuis
01:27 PM Revision 8135ac1b (main_repo): net: handle 'finish' event only after 'connect'
Fedor Indutny
01:16 PM Revision 53f23814 (main_repo): core: Unwrap without aborting in handle fd getter
isaacs
01:15 PM Revision 7a07b31a (main_repo): blog: Fix typo in typo fix
isaacs
09:24 AM Revision 26dae9a2 (main_repo): net: handle 'finish' event only after 'connect'
Fedor Indutny
10:00 PM Revision 598b5e45 (main_repo): blog: fix small typo in v0.10.0 release article
Nathan Rajlich

03/12/2013

06:59 PM Revision 3288bc95 (main_repo): doc: fix inpect() -> inspect() typo
Nathan Rajlich
04:23 PM Revision 68487a73 (main_repo): crypto: replace BIO_free with BIO_free_all
From OpenSSL's documentation:
"If BIO_free() is called on a BIO chain it will only free one BIO
resulting in a memor...
Fedor Indutny
04:23 PM Revision 78459182 (main_repo): crypto: refactor crypto classes
Fedor Indutny
04:23 PM Revision a15cc93a (main_repo): crypto: split crypto classes
Fedor Indutny
04:23 PM Revision 83d17e50 (main_repo): crypto: merge Cipher and Decipher
Fedor Indutny
04:18 PM Revision 66280de1 (main_repo): util: custom `inspect()` method may return an Object
This is more like how `JSON.stringify()` works.
Closes #2711.
Nathan Rajlich
04:15 PM Revision da8b0eef (main_repo): console: `console.dir()` bypasses inspect() methods
Use the `customInspect: false` option of `util.inspect()` to bypass any custom
inspect() function on the object being...
Nathan Rajlich

03/11/2013

07:07 PM Revision da10bb85 (main_repo): doc: events: add 'removeListener' event section
Amends commit 84221fd by (also) documenting the 'removeListener' event
in a dedicated section, like the 'newListener'...
Ben Noordhuis
01:19 PM Revision 228ad935 (main_repo): blog: Post about v0.10.0
isaacs
11:49 AM Revision e2b293c3 (main_repo): Now working on 0.10.1
isaacs
11:49 AM Revision dcfb6d82 (main_repo): Merge branch 'v0.10.0-release' into v0.10
isaacs
08:36 PM Revision 163ca274 (main_repo): 2013.03.11, Version 0.10.0 (Stable)
* npm: Upgrade to 1.2.14
* core: Append filename properly in dlopen on windows (isaacs)
* zlib: Manage flush flags ...
isaacs

03/10/2013

02:08 PM Revision 327b6e3e (main_repo): stream: Don't emit 'end' unless read() called
This solves the problem of calling `readable.pipe(writable)` after the
readable stream has already emitted 'end', as ...
isaacs
02:04 PM Revision cd2b9f54 (main_repo): stream: Avoid nextTick warning filling read buffer
In the function that pre-emptively fills the Readable queue, it relies
on a recursion through:
stream.push(chunk) ->...
isaacs
12:53 PM Revision 738347b9 (main_repo): events: Handle missing error obj when domains in use
so `ee.emit('error')` doesn't throw when domains are active
create an empty error only when handled by a domain
tes...
Julian Gruber
07:14 AM Revision c9a4ec9c (main_repo): http: ServerRequest does not timeout after 'end'
Fixes #4967 koichik
05:34 AM Revision e2400f88 (main_repo): http: Do not setTimeout a not-yet-existent socket
Fixes #4967 isaacs
09:34 PM Revision 21a99664 (main_repo): uv: Upgrade to 5462dab
isaacs

03/09/2013

12:22 PM Revision 12713c3b (main_repo): win/msi: Fix typos
isaacs
12:11 PM Revision 31b5d41f (main_repo): npm: Upgrade to 1.2.14 (fixed)
isaacs
11:46 AM Revision 5757ce48 (main_repo): http: check if incoming parser has already been freed
Fix #4948
This adds a check before setting the incoming parser
to null. Under certain circumstances it'll already be...
hc
11:19 AM Revision 7becf156 (main_repo): timers: consistent this keyword in setImmediate
When calling setImmediate with extra arguments the this keyword in the
callback would refer to the global object, but...
Andreas Madsen
10:00 AM Revision 80472bc3 (main_repo): domain: Fix double-exit on nested domains
Minor oversight in fix for #4953. isaacs
12:52 AM Revision 43c1830e (main_repo): Now working on 0.11.0
isaacs
12:52 AM Revision 4d1e9e53 (main_repo): Now working on 0.10.0
isaacs
11:26 PM Revision 7c9ff8e9 (main_repo): lint
isaacs
11:09 PM Revision 77a776da (main_repo): stream: Always defer preemptive reading to improve latency
Gil Pedersen
09:59 PM Revision 061a7ddb (main_repo): Merge remote-tracking branch 'ry/v0.8' into master
Conflicts:
AUTHORS
ChangeLog
src/node_version.h
isaacs
09:56 PM Revision 98c6a817 (main_repo): test: Kill zombies when debugger-client fails on windows
isaacs
09:56 PM Revision 6e34dfd9 (main_repo): test: Fail faster in simple/test-cluster-bind-twice-v2
Crashing on windows, but at least now it's a crash rathert han a timeout. isaacs
09:56 PM Revision 8cf2d4c2 (main_repo): test: Don't run async operation in process 'exit'
Also, this seems to occasionally cause some annoying file-locking
errors in Windows. Not sure if this is the best fi...
isaacs
09:56 PM Revision f5c293b5 (main_repo): test: Use copy instead of symlink in child-process-fork-exec-path
isaacs
09:56 PM Revision 9826159b (main_repo): test: Trim cat output for windows
isaacs
09:56 PM Revision 99a2059e (main_repo): test: Sending dgram sockets to child procs not supported on windows
isaacs
09:56 PM Revision 6076a25e (main_repo): core: Append filename properly in dlopen on windows
Fixes simple/test-module-loading on win32 isaacs
09:56 PM Revision 08f5db11 (main_repo): test: Make stream2-transform less timing-dependent
isaacs
09:56 PM Revision 6d593a90 (main_repo): test: Don't fail tls-session-cache if openssl is bad
isaacs
09:56 PM Revision b3cbb16f (main_repo): zlib: Manage flush flags appropriately
If you call z.flush();z.write('foo'); then it would try to write 'foo'
before the flush was done, triggering an asser...
isaacs

03/08/2013

05:46 PM Revision 29cd0f2a (main_repo): domains: Handle errors thrown in nested error handlers
If a domain error handler throws, it should be caught if it was
in a stack of nested domains.
Fix #4953
isaacs
05:42 PM Revision e325ace5 (main_repo): buffer: speed up ascii character scanning
Speed up ASCII character scanning and conversion by 25% to 30% by scanning and
converting whole words instead of indi...
Ben Noordhuis
05:42 PM Revision 96a314b6 (main_repo): buffer: strip high bits when converting to ascii
Consider the following example:
console.log(Buffer('ú').toString('ascii'));
Before this commit, the contents of t...
Ben Noordhuis
05:35 PM Revision 632b7d87 (main_repo): Revert "http: check if incoming parser has already been freed"
This reverts commit 9f4c3b0d45f858d3d3021ef4b8edebf6005008ff. isaacs
05:14 PM Revision 9f4c3b0d (main_repo): http: check if incoming parser has already been freed
Fix #4948
This adds a check before setting the incoming parser
to null. Under certain circumstances it'll already be...
hheennrryy@gmail.com
04:47 PM Revision ea30ca95 (main_repo): doc: Add wrk's license to LICENSE file
isaacs
12:00 PM Revision 3c22c425 (main_repo): win/msi: enable modify and repair
Bert Belder
12:00 PM Revision fa1efa36 (main_repo): win/msi: miscellaneous style cleanups
Bert Belder
12:00 PM Revision 4147680d (main_repo): win/msi: don't include architecture in start menu group name
Bert Belder
12:00 PM Revision 8365a565 (main_repo): win/msi: update 'install finished' message
Bert Belder
12:00 PM Revision 952d6c5e (main_repo): win/msi: clean up the 'documentation shortcuts' feature
Bert Belder
12:00 PM Revision fb625320 (main_repo): win/msi: refactor 'node.js runtime' feature
* This feature now includes the start menu items.
* 'nodejsvars.bat' was renamed to 'nodevars.bat'.
* Improved featur...
Bert Belder
12:00 PM Revision 5e832ac7 (main_repo): win/msi: separate features for ETW and perfctr support
Bert Belder
12:00 PM Revision 2320ffbd (main_repo): win/msi: make 'add to path' a separate feature
Bert Belder
12:00 PM Revision 51e3a599 (main_repo): win/msi: make npm a feature separate from the runtime
Bert Belder
12:00 PM Revision 4348241b (main_repo): win/msi: use consistent registry key paths
Bert Belder
12:00 PM Revision 8542c9af (main_repo): win/msi: don't install pdb file
It's only available in debug builds, and we're not providing
installer packages for debug builds anyway.
Bert Belder
12:00 PM Revision 0604d9ab (main_repo): win/msi: don't create empty npm folder in %appdata%
Npm creates this folder when it's needed. Creating it in the installer
violates the per-user / per-machine scope sepa...
Bert Belder
12:00 PM Revision 75147793 (main_repo): win/msi: define features before directories/components
Bert Belder
12:00 PM Revision 52f7a14a (main_repo): win: make nodejsvars.bat detect whether npm is available
Bert Belder
10:35 AM Revision 90368770 (main_repo): stream: Emit error on stream object, not global
Apparently this function got abstracted out at some point, and 'this'
wasn't changed to the correct object.
isaacs
06:43 AM Revision d5959c5c (main_repo): Revert "build, windows: disable SEH"
This is no longer necessary - the underlying issue was fixed in 01fa5ee.
This reverts commit d87904286024f5ceb6a2d0d5...
Bert Belder
06:43 AM Revision 34461572 (main_repo): win/openssl: mark assembled object files as seh safe
There are no unsafe structured exception handlers in object files
generated from hand-crafted assembly - because they...
Bert Belder
06:38 AM Revision 95871ac1 (main_repo): windows/msi: fix msi build issue with WiX 3.7/3.8
The `heat` tool that gathers NPM source files wasn't getting called.
Closes #4896
Raymond Feng
09:17 PM Revision 4b47bb4d (main_repo): uv: Upgrade to b68ee40
isaacs

03/07/2013

02:56 PM Revision e7b8bad3 (main_repo): bench: Do math on numbers in compare.js, not strings
isaacs
02:53 PM Revision f23ec6b3 (main_repo): uv: Upgrade to f89125e
isaacs
11:51 AM Revision bdf7ac2c (main_repo): child_process: support sending dgram socket
child.send can send net servers and sockets. Now that we have support
for dgram clusters this functionality should be...
Andreas Madsen
08:13 AM Revision 71694361 (main_repo): doc: dgram: add v0.10 bind() behavior note
dgram.Socket#bind() is always asynchronous now. Add a note at the top
of the documentation that explains how to upgra...
Ben Noordhuis
08:11 AM Revision 924f603e (main_repo): doc: dgram: document bind() callback argument
Ben Noordhuis
07:22 PM Revision 9c581257 (main_repo): blog: Post for v0.8.22
isaacs
07:20 PM Revision 5c3c2ed9 (main_repo): Now working on 0.8.23
isaacs
07:19 PM Revision d7a5f96f (main_repo): Merge branch 'v0.8.22-release' into v0.8
isaacs

03/06/2013

06:47 PM Revision 67a4cb4f (main_repo): 2013.03.07, Version 0.8.22 (Stable)
* npm: Update to 1.2.14
* cluster: propagate bind errors (Ben Noordhuis)
* crypto: don't assert when calling Cipher...
isaacs
06:43 PM Revision f780c6f5 (main_repo): Merge remote-tracking branch 'ry/v0.8' into master
Conflicts:
deps/npm/html/api/bin.html
deps/npm/html/api/bugs.html
deps/npm/html/api/commands.html
deps/npm/html/a...
isaacs
06:41 PM Revision 80fb5809 (main_repo): npm: Update to 1.2.14
isaacs
05:19 PM Revision 277a2545 (main_repo): blog: Update streams2 feature post to match actual doc
isaacs
04:59 PM Revision 7df4652d (main_repo): Now working on 0.9.13
Probably that will be 0.10.0 instead, though. isaacs
04:59 PM Revision ff2639f9 (main_repo): doc: fix ChangeLog typo
isaacs
04:59 PM Revision b5dffdd6 (main_repo): Merge branch 'v0.9.12-release'
isaacs
04:57 PM Revision 116d6c44 (main_repo): blog: Post for 0.9.12
isaacs
04:06 PM Revision 0debf5a8 (main_repo): 2013.03.06, Version 0.9.12 (Unstable)
* stream: Allow strings in Readable.push/unshift (isaacs)
* stream: Remove bufferSize option (isaacs)
* stream: Inc...
isaacs
03:59 PM Revision 51c8b0ed (main_repo): V8: Reapply floating patches
isaacs
03:59 PM Revision 81c278d5 (main_repo): V8: Upgrade to 3.14.5.8
isaacs
03:43 PM Revision d258fb02 (main_repo): http: More useful setTimeout API on server
This adds the following to HTTP:
* server.setTimeout(msecs, callback)
Sets all new connections to time out after t...
isaacs
03:33 PM Revision db5d58e8 (main_repo): bench: Use environ to run compares more than once
This will run the benchmarks the number of times specified by NODE_BENCH_RUNS,
to attempt to reduce variability.
If ...
isaacs
02:44 PM Revision 9208c890 (main_repo): stream: Raise readable high water mark in powers of 2
This prevents excessively raising the buffer level in tiny increments in
pathological cases.
isaacs
02:44 PM Revision a978bede (main_repo): stream: Allow strings in Readable.push/unshift
Fix #4909 isaacs
02:44 PM Revision 8c44869f (main_repo): stream: Increase highWaterMark on large reads
If the consumer of a Readable is asking for N bytes, and N > hwm,
then clearly we have set the hwm to low, and ought ...
isaacs
02:44 PM Revision d5a0940f (main_repo): stream: Remove pipeOpts.chunkSize
It's not actually necessary for backwards compatibility, isn't
used anywhere, and isn't even tested. Better to just ...
isaacs
02:44 PM Revision b0f6789a (main_repo): stream: Remove bufferSize option
Now that highWaterMark increases when there are large reads, this
greatly reduces the number of calls necessary to _r...
isaacs
02:44 PM Revision e0cec37d (main_repo): stream: Remove unnecessary nextTick usage in Writable
Fix #4928 isaacs
02:44 PM Revision 32ac8c0b (main_repo): test: Pass cli flags in pummel/test-regress-GH-892
isaacs
02:44 PM Revision 5038f401 (main_repo): node: Add --throw-deprecation
Extremely handy when tracking down a flood of recursive nextTick warnings. isaacs
01:45 PM Revision 25ba971f (main_repo): http: fix multiple timeout events
Fixed up slightly by @isaacs so as not to miss 'timeout' events in some
cases.
Eugene Girshov
10:15 AM Revision fb3ec32b (main_repo): net: use close callback, not process.nextTick
Don't emit the 'close' event with process.nextTick.
Closing a handle is an operation that usually *but not always* c...
Ben Noordhuis
09:32 AM Revision 958ab661 (main_repo): handle_wrap: add close callback support
Ben Noordhuis
09:25 AM Revision 3d20905b (main_repo): handle_wrap: replace unref_ field with flags_ field
Prep work for a follow-up commit that adds support for close callbacks. Ben Noordhuis
08:45 AM Revision 3dbbfd78 (main_repo): src: remove unused symbols in node_file.cc
Ben Noordhuis
05:31 AM Revision 2ad98725 (main_repo): DNS: Support NAPTR queries
They were previously removed in a90bc78534d94940a6b726c01cf8427c296b4c63. Pavel Lang
05:10 AM Revision 74784b63 (main_repo): cares: Set process._errno, not global.errno
This makes test-internet pass isaacs
02:47 AM Revision 323120b5 (main_repo): child_process: handle ENOENT correctly on Windows
Scott Blomquist
12:15 AM Revision 4d809e29 (main_repo): process: invoke EventEmitter on `process`
This properly sets the `_maxListeners` property, which
fixes the max listener warning. Closes #4924.
Nathan Rajlich

03/05/2013

05:43 PM Revision f9ba9f7b (main_repo): build: define nightly tag external to build system
Timothy J Fontaine
05:27 PM Revision 312289b7 (main_repo): stream: Use class for write buffer entries
isaacs
05:27 PM Revision 426b4c62 (main_repo): stream: _write takes an encoding argument
This vastly reduces the overhead of decodeStrings:false streams,
such as net and http.
isaacs
05:27 PM Revision cd68d86c (main_repo): stream: Remove output function from _transform
Just use stream.push(outputChunk) instead. isaacs
05:26 PM Revision 049903e3 (main_repo): stream: Split Writable logic into small functions
1. Get rid of unnecessary 'finishing' flag
2. Dont check both ending and ended. Extraneous.
Also: Remove extraneous ...
isaacs
05:23 PM Revision e4383c01 (main_repo): bench: Add flag to be silent in runner
This is helpful in tracking down bailouts and deopts in Stream classes,
without triggering one from the string write ...
isaacs
05:06 PM Revision dd6432dc (main_repo): process: invoke EventEmitter on `process`
This properly sets the `_maxListeners` property, which
fixes the max listener warning. Closes #4924.
Nathan Rajlich
01:40 PM Revision c0a5af8d (main_repo): Revert "build, windows: disable SEH"
This is no longer necessary - the underlying issue was fixed in 01fa5ee.
This reverts commit d87904286024f5ceb6a2d0d5...
Bert Belder
01:39 PM Revision 01fa5ee2 (main_repo): win/openssl: mark assembled object files as seh safe
There are no unsafe structured exception handlers in object files
generated from hand-crafted assembly - because they...
Bert Belder
11:15 AM Revision 8e2376b3 (main_repo): Update domain.markdown
Paolo Fragomeni
10:10 AM Revision f7b06e0b (main_repo): deps: upgrade libuv to 0b26af3
Ben Noordhuis
09:43 AM Revision 862f7b85 (main_repo): Merge remote-tracking branch 'origin/v0.8'
Ben Noordhuis
09:23 AM Revision 532d9929 (main_repo): cluster: propagate bind errors
This commit fixes a bug where the cluster module fails to propagate
EADDRINUSE errors.
When a worker starts a (net, ...
Ben Noordhuis
03:47 AM Revision 3e64b567 (main_repo): events: loop backwards in removeListener
`removeAllListeners` is removing events from end to start. Therefore
it spends O(n^2) time, since `removeListener` is...
Felix Böhm

03/04/2013

02:59 PM Revision d09ab61d (main_repo): events: code consistency
v8 likes when smaller functions have a single return point, and cleaned
up the single non-strict check.
Trevor Norris
02:57 PM Revision 04688614 (main_repo): events: remove type check for event type
Strict checking for typeof types broke backwards compatibility for other
libraries. This reverts those checks.
The s...
Trevor Norris
02:54 PM Revision ecf9f606 (main_repo): doc: add url.resolve() usage examples
Fixes #4913. Ben Noordhuis
01:47 PM Revision 890dc2ee (main_repo): win/msi: make msi build work when spaces are present in the path
Bert Belder
10:38 AM Revision 119cbf48 (main_repo): stream: Don't require read(0) to emit 'readable' event
When a readable listener is added, call read(0) so that data will flow in, up to
the high water mark.
Otherwise, it'...
isaacs
10:20 AM Revision 009ba02e (main_repo): dns: fix ReferenceError in resolve() error path
A typo in the variable name makes it throw a ReferenceError instead of
the expected "Unknown type" error when dns.res...
Xidorn Quan
01:12 AM Revision a6a1659d (main_repo): link to LevelUP modules wiki page, not level-hooks
Rod Vagg
01:12 AM Revision 906f824b (main_repo): link to LevelUP modules wiki page, not level-hooks
Rod Vagg
08:26 PM Revision e428bb7e (main_repo): cluster: Rename destroy() to kill(signal=SIGTERM)
Fix #4133, bringing the cluster worker API more in line with the
child process API.
isaacs
08:26 PM Revision 384f1be7 (main_repo): stream: Writable.end(chunk) after end is an error
Calling end(data) calls write(data). Doing this after end should
raise a 'write after end' error.
However, because ...
isaacs

03/03/2013

06:30 PM Revision 0c57b311 (main_repo): doc: Add crypto.pseudoRandomBytes, fix typo
Aaron Cannon
06:28 PM Revision 22aa7674 (main_repo): make repl compatible with domains
The try/catch in repl.js keeps any active domain from catching the
error. Since the domain may not even be enterd un...
Dave Olszewski
08:21 PM Revision 80ea63b9 (main_repo): Revert "stream: Writable.end(chunk) after end is an error"
It's breaking ~22 tests, Needs further investigation.
This reverts commit 5222d19a11ed0e29d207da0e8c9c8e0e3b18ad78.
Ben Noordhuis
07:10 PM Revision f5d84965 (main_repo): doc: Typo in ChangeLog
downgrade TO 3.14 isaacs
07:09 PM Revision 5222d19a (main_repo): stream: Writable.end(chunk) after end is an error
Calling end(data) calls write(data). Doing this after end should
raise a 'write after end' error.
However, because ...
isaacs

03/02/2013

06:11 PM Revision 63edde0e (main_repo): events: Handle emit('error') before ctor
The previous commit did not handle the case when the event type
is 'error', since that is checked before reading the ...
isaacs
06:01 PM Revision d345c117 (main_repo): events: Handle emit before constructor call
isaacs
05:13 PM Revision 2d51036f (main_repo): Merge remote-tracking branch 'origin/v0.8'
Conflicts:
doc/api/http.markdown
test/simple/test-crypto.js
Ben Noordhuis
05:04 PM Revision 426cbedb (main_repo): test: make simple/test-dgram-pingpong respect PORT
Don't use hard-coded port numbers, use common.PORT instead.
Should fix the occasional Jenkins failure; the builds ru...
Ben Noordhuis
02:50 PM Revision 4ac73d2c (main_repo): net: s/closed/ended/ in write-after-fin message
isaacs
02:26 PM Revision 2106ef00 (main_repo): net: Provide better error when writing after FIN
The stock writable stream "write after end" message is overly vague, if
you have clearly not called end() yourself ye...
isaacs
02:06 PM Revision 47e11506 (main_repo): windows/msi: fix msi build issue with WiX 3.7/3.8
The `heat` tool that gathers NPM source files wasn't getting called.
Closes #4896
Raymond Feng
01:09 PM Revision 0b70a14a (main_repo): test: optionally set common.PORT via env variable
This is a back-port of commit 17a8126 from the master branch. Timothy J Fontaine
08:43 PM Revision 93156a60 (main_repo): test: unlink temp file at test start
The file has a long name that's apparently impossible to remove with
`git clean` on Windows.
Ben Noordhuis
08:36 PM Revision d1b4dcd6 (main_repo): events: add type checks to once
Also cleanup unnecessary use of "self" since it will always be called
using .apply() from emit.
Trevor Norris
08:36 PM Revision e1ac2ef7 (main_repo): events: emit cleanup
Cleanup check logic. Place vars at top. Remove PROCESS. Trevor Norris
08:36 PM Revision 1ccc6fbe (main_repo): events: additional type check for addListener
Check both passed args to addListener.
Place var at beginning.
Trevor Norris
08:36 PM Revision 4f7f8bbd (main_repo): events: _events to object and undefined not null
By making sure the _events is always an object there is one less check
that needs to be performed by emit.
Use undef...
Trevor Norris
08:36 PM Revision b3ea8443 (main_repo): events: removeListener add checks and cleanup
Remove unecessary splice for single listener events. Add type check for
"type" argument.
Trevor Norris
08:36 PM Revision aba03ebb (main_repo): events: type check listeners
Make sure the argument passed is a string. Also use typeof === function
check instead of isArray().
Trevor Norris
08:36 PM Revision 8ab346c9 (main_repo): events: simplify removeAllListeners logic
Unnecessary checks were being performed on if the event existed before
being removed.
_events starts out as null, so...
Trevor Norris
08:36 PM Revision dd171d24 (main_repo): events: type check setMaxListeners, cleanup throws
setMaxListeners will now make sure a positive number is passed. Also
throwing more definitive Error types.
Trevor Norris
08:36 PM Revision 75305f3b (main_repo): events: add check for listeners length
Ability to return just the length of listeners for a given type, using
EventEmitter.listenerCount(emitter, event). Th...
Trevor Norris
08:36 PM Revision 8ca43a7f (main_repo): events: ensure usingDomain is always boolean
Small addition to ensure that exports.usingDomains is always a bool. Trevor Norris
08:13 PM Revision 7189b3ed (main_repo): crypto: don't assert when calling Cipher#final() twice
Remove the assert() that triggered when Cipher#final() or
Decipher#final() was called twice.
Fixes #4886.
Ben Noordhuis
07:49 PM Revision 7707acd6 (main_repo): deps: upgrade libuv to 7e59f9b
Ben Noordhuis
07:33 PM Revision 4b20f344 (main_repo): doc change for Readable._read()
Lars-Magnus Skog

03/01/2013

05:26 PM Revision fc229860 (main_repo): doc: Clarify advisory-ness of stream._read() argument
isaacs
05:23 PM Revision 13c8bc89 (main_repo): doc: Update to reflect new _read() interface
Gil Pedersen
05:21 PM Revision 16ddc545 (main_repo): doc: Fix readable.unshift() example
Slice the portion of the buffer to unshift back into the read queue Evan Oxfeld
04:30 PM Revision 6366a305 (main_repo): build/windows: don't use wrong version number
We were using a global temp file while setting the NODE_VERSION
environment variable. This resulted in simultaneous b...
Scott Blomquist
02:24 PM Revision be770a38 (main_repo): blog: Post about v0.9.11
isaacs
02:23 PM Revision 33aafbd8 (main_repo): doc: Correct version in changelog
isaacs
02:19 PM Revision 4cda016c (main_repo): Now working on 0.9.12
isaacs
02:19 PM Revision 300802d5 (main_repo): Merge branch 'v0.9.11-release'
isaacs
01:59 PM Revision 83392403 (main_repo): 2013.03.01, Version 0.9.10 (Unstable)
* V8: downgrade 3.14.5
* openssl: update to 1.0.1e
* darwin: Make process.title work properly (Ben Noordhuis)
* fs...
isaacs
01:58 PM Revision 687522c5 (main_repo): blog: Do not pass undefined to path.join
isaacs
12:48 PM Revision 0928a526 (main_repo): fs: Support mode/flag options to read/append/writeFile
Fix #4841 isaacs
11:55 AM Revision 55aa973b (main_repo): test: Put fs write test files in tmp
This prevents fixture litter when these tests fail. isaacs
07:11 AM Revision f26362e9 (main_repo): http: use socket.once, not socket.on
Register the 'close' event listener with .once(), not .on().
It doesn't matter in the grand scheme of things because...
Ben Noordhuis
 

Also available in: Atom