CSE2410 Fall 2014 the Passive Aggressors

Move generating HAVE_AIRPCAP to main CMakeLists.txt as is done with
other liberaries. Also: After set( variable 0 ) the variable is defined.

Change-Id: Id26a771875b7643c19f173ce77bb29a4059a1bd0
Reviewed-on: https://code.wireshark.org/review/3793
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

In Visual Studio builds, enable the L4 warning
4189: Local variable is initialized but not referenced

Fix some variables found by this

Change-Id: Icc13def5413f1fe885ec25e659462c8906a6cfa0
Reviewed-on: https://code.wireshark.org/review/3748
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>...

Windows Qt: Add taskbar progress support

Add support for the taskbar progress indicator on Windows via
QtWinExtras. It is almost as if we're a grown up Windows application.

Change-Id: I378206b49510d4bd08f2437d8e9a1b01bc6f1351
Reviewed-on: https://code.wireshark.org/review/3576...

Suppress 10 of the CMP0020 CMake warnings on Windows, only 8 left now.

Change-Id: I2f85529728e0346b8c4888cd1c23e86a306cc613
Reviewed-on: https://code.wireshark.org/review/3430
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>

CMake 2.8+ supports CMAKE_OSX_DEPLOYMENT_TARGET; don't do that stuff ourselves.

Do, however, do the "for a target of 10.4 or 10.5, build 32-bit only"
stuff, as that's specific to programs that capture traffic, such as
Wireshark (well, I guess we could just limit it to dumpcap, but...)....

Go back to non-verbose Makefiles.

(The difference in question turned out to be that optimization wasn't
turned on for autotools builds but was turned on for CMake builds.
Comparing the compiler options also found some other differences that
should be cleaned up.)...

Print the actual compiler, not its "CMake-id".

Hopefully this will help figure out whether we're using different
compilers for the autotools and CMake builds.

Change-Id: If6d2ee93cd14570c53723140dcedf347600cbe34
Reviewed-on: https://code.wireshark.org/review/3375...

Note that the ...COMMON_FLAGS are for C and C++.

Change-Id: I0ef87b3b4aaed984a8a53660b36746345626583a
Reviewed-on: https://code.wireshark.org/review/3373
Reviewed-by: Guy Harris <guy@alum.mit.edu>

When testing compiler flags, test them with previously-tested flags.

That mirrors what we're doing with autotools, and catches cases where
an earlier-tested flag affects the results for a later-tested flag
(e.g., -fwrapv can affect whether -fno-strict-overflow produces a...

Wait until the C and C++ compiler flags are fully set before showing them.

That way, we report the full contents of those flags.

Change-Id: Idab78049247c04b7d35a3ce804c8ea9daaf84312
Reviewed-on: https://code.wireshark.org/review/3364
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Move the AirPcap stuff into caputils.

Change-Id: I64b45dad36a3ec491aeb9de3439b4fe19b46f9d8
Reviewed-on: https://code.wireshark.org/review/3308
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Lua - it's not just for breakfast^Wdissectors any more!

Change-Id: I7cefdec10a2fdd47f8a50ab5a45002662cc14f3c
Reviewed-on: https://code.wireshark.org/review/3302
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Move the monitor-for-interface-list-changes stuff to the caputils library.

Change-Id: Ie0d4504688602c2aa8e9788643b079930ca7d305
Reviewed-on: https://code.wireshark.org/review/3076
Reviewed-by: Guy Harris <guy@alum.mit.edu>

CMake : fix name of HTML Viewer to display also the exe path

Change-Id: Id103ced59e0ae7e2cff272604f4cfe11d47fe957
Reviewed-on: https://code.wireshark.org/review/2950
Reviewed-by: Evan Huus <eapache@gmail.com>

Make wsutil depend on gitversion.

wsutil contains the only code that uses version.h; make the dependency
explicit, to see whether that fixes the current build issues with Debian
packaging.

Also, get rid of all other dependencies on gitversion.

Change-Id: I89fa5e4112633b83a1a7dfa349bc337e3688575f...

Make --help and --version information a bit more uniform.

Have --version print the version number, the copyright information, the
"compiled with" information, the "running on/with" information, and the
compiler information.

Have --help print the version number, a one-line summary of what the...

Allow overriding C/C++ flags from CMake command line

Append user's flags to our flags instead of prepending them to make
user flags higher priority.

Change-Id: I3ead33ee5fa06a2395d9197a027306ef99a704a2
Reviewed-on: https://code.wireshark.org/review/2722...

AUTHORS-SHORT is build in ${CMAKE_BINARY_DIR}, not ${CMAKE_SOURCE_DIR}.

Make the dependencies list indicate that.

Change-Id: I88416e1239130b7661bbd9deccfb289e0b0fd627
Reviewed-on: https://code.wireshark.org/review/2770
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Put each option on a line of its own.

Change-Id: Ibec60300306e8af7ee230080b113111f93d850dc
Reviewed-on: https://code.wireshark.org/review/2739
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

Move proto_hier_stats.[ch] to libui.

Change-Id: Ib7c0617d88bf92cad0ac877176001d29960f1cd8
Reviewed-on: https://code.wireshark.org/review/2725
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Move capture_ui_utils.[ch] to libui.

Change-Id: Id0f3d4d60a1acc7aa64fd3737b8f16df5bca4e5a
Reviewed-on: https://code.wireshark.org/review/2708
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Fixed linker flags for MSVC to not attempt to make and link a manifest
Added solution "folder" for tests.

Change-Id: I96dfb4a28fb7aaf3e84cea026e1f5d15afe6c0c6
Reviewed-on: https://code.wireshark.org/review/2635
Tested-by: Graham Bloice <graham.bloice@trihedral.com>...

Move the routines to talk to dumpcap into a static libcapchild.

This pulls some stuff out of the top-level directory, and means we don't
have to build them once for every program using them.

Change-Id: I37b31fed20f2d5c3563ecd2bae9fd86af70afff5
Reviewed-on: https://code.wireshark.org/review/2591...

Move get_os_version_info() to libwsutil.

This mean we also have to move CFString_to_C_string() there for OS X.

Change-Id: Ic91ad872e9d5290cf34f842503ededd5452e4337
Reviewed-on: https://code.wireshark.org/review/2511
Reviewed-by: Guy Harris <guy@alum.mit.edu>

More .in files to handle

Change-Id: I55a04fe6f72c22f1a936ef45b215a8813f7a02db
Reviewed-on: https://code.wireshark.org/review/2502
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

Add flags required for VS2013 to Cmake

Change-Id: I666d819fdee67d945dd46bd03749f190eb2873b4
Reviewed-on: https://code.wireshark.org/review/2499
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Graham Bloice <graham.bloice@trihedral.com>

Only check for -msse4.2.

We don't care about instruction set extensions other than SSE 4.2, just
check for that.

Do so on all compilers other than MSVC.

Change-Id: I227c31715aab6df0e020d6bc3e3aa41e1bc5cb7e
Reviewed-on: https://code.wireshark.org/review/2405...

We don't need -Werror=unknown-warning-option with Clang.

check_c_compiler_flag checks for the message Clang prints for an unknown
warning option ("unknown warning option '-WXXX'"), and fails if it's
produced, so we don't need to force the compiler to fail by passing it...

Remove detection of Python libraries: They are not used anymore.

Change-Id: If42bb16d5c6202889ff933af6c9d974866d2a950
Reviewed-on: https://code.wireshark.org/review/2290
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

The visibility warning is only valid on non-msvc platforms

Change-Id: Iec90ac8654d08b63cfda7d14c370f3c800c74038
Reviewed-on: https://code.wireshark.org/review/2263
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

Match for contents of WIRESHARK_SIMD_FLAGS only if non-empty

Change-Id: I99e15b237c74783b455461ce58ba32f1f8202990
Reviewed-on: https://code.wireshark.org/review/2208
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

Rename WIRESHARK_C_FLAGS to WIRESHARK_COMMON_FLAGS

Change-Id: If78801de797264c0924e81abaf8cd49cc5715a83
Reviewed-on: https://code.wireshark.org/review/2204
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

Update CMake build for win32 to build QT again, and to find
GLib and GThread libs

Change-Id: If7e8ebc46f42389d174959303e13cde20687ae8a
Reviewed-on: https://code.wireshark.org/review/2010
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Graham Bloice <graham.bloice@trihedral.com>...

Fix wireshark.pc install destination

Change-Id: I136d654ac5ea54237494d9b61c3ddb445b0720ae
Reviewed-on: https://code.wireshark.org/review/1863
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Commit 5ff629ec5ac636b901b2a004aa4d5248f68a5d0f requires the minimum
cmake version to be 2.8.3. Make this explicit.

commit 5ff629ec5ac636b901b2a004aa4d5248f68a5d0f
  Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
  Date:   Thu May 22 22:05:08 2014 +0200...

Update comment about -Wunreachable-code and -Wdocumentation

Change-Id: I5b942bdacc5f4a9ecfa084dbff479eba6582b0df
Reviewed-on: https://code.wireshark.org/review/1726
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Not finding a non-required package is NOT an error!

If you think not finding a package that the user specifies should be
used should be an error, please fix bug 10074 first - not finding a
package that the user didn't specify should be used or shouldn't be...

Fix procedure of finding packages

Before this change the code using make package was just showing
a string ${PACKAGE_VAR}_FOUND instead of showing if the
${PACKAGE_VAR}_FOUND variable was set true by find_package function.
Now the user will be informed about which packages were not found...

Rename ENABLE_EXTRA_COMPILER_CHECKS to ENABLE_EXTRA_COMPILER_WARNINGS.

This matches the current name of the --enable-extra-compiler-warnings
option in autotools.

Fix the documentation of the option to match.

(Note that "compiler" won't necessarily always be GCC or Clang, and...

Don't distinguish between "GCC" and "Clang" extra -W flags.

We test whether a given compiler supports a given -W flag, so we don't
need to separate them and check them only for particular compilers.

To make that even clearer, rename the --enable option from...

Change how WERROR and WERR_UNKNOWN is turned off

Use setting WERROR and WERR_UNKNOWN explicitly to
FALSE instead using unset command. This ensures that
no if(WERROR) or if(WERR_UNKNOWN) clause will trigger
unless these variables are set to another value....

Add --enable-extra-clang-checks for autotools and CMakeList
With -Wunreachable-code flags (and disable for the moment -Wdocumentation)

Change-Id: I126c962b32e650a63b78092e95896736ae7335c9
Reviewed-on: https://code.wireshark.org/review/678
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Add pkg-config file

Change-Id: Ia55a2e560aef8d2f9a3cede18af4555507656047
Reviewed-on: https://code.wireshark.org/review/500
Reviewed-by: Evan Huus <eapache@gmail.com>
Tested-by: Balint Reczey <balint@balintreczey.hu>
Reviewed-by: Balint Reczey <balint@balintreczey.hu>

Add Bluetooth SBC Codec support in cmake

SBC Codec can be optionally linked with Wireshark to provide
ability to playing RTP/SBC stream by RTP Player.

Change-Id: Iffbae16a741ffbfd0fb55a300064739d2c27c2e5
Reviewed-on: https://code.wireshark.org/review/223...

Replace "svn" with "git" all over the place.

Rename "SVNPATH" to "GITBRANCH" since that seems more appropriate.
Rename "svnversion.h" to "version.h" as Evan suggested. Update some
URLs. In make-version.pl, make sure we don't set an improper upstream
branch name. Use the number of commits + short hash from `git describe`...

Add option to specify special permissions for dumpcap during cmake phase:
set(DUMPCAP_INSTALL_OPTION <val>)
where val is one of "normal" "suid" "capabilities"

Some things left to do:
- Error out in cmake if setcap isn't found or libcap isn't found.
- Move multivalue option handling into it's own macro (-file) with...

Move cfile.c into SHARK_COMMON_SRC (as was done in nmake)

svn path=/trunk/; revision=54678

TFShark doesn't capture traffic, so it doesn't need
SHARK_COMMON_CAPTURE_SRC.

svn path=/trunk/; revision=54672

Rename WIRESHARK_COMMON_SRC to SHARK_COMMON_SRC - what's common about it
is that it includes files used in TShark and rawshark as well as
Wireshark, and that name is what's used by the autotools.

Add capture_sync.c to SHARK_COMMON_CAPTURE_SRC, as it's used both by...

Rework compiler flag detection to be able to handle changed
order of flags

svn path=/trunk/; revision=54638