The data contained in this repository can be downloaded to your computer using one of several clients.
Please see the documentation of your version control software client for more information.

Please select the desired protocol below to get the URL.

This URL has Read-Only access.

Statistics
| Branch: | Revision:

main_repo / color_filters.c @ master

History | View | Annotate | Download (23.9 KB)

# Date Author Comment
97546165 08/24/2014 04:04 AM Graham Bloice

Modify includes of config.h so that out-of-tree builds, i.e. CMake
don't pick up the in-tree copy.

Change-Id: I7ec473876cdba1a025c52362d7f6adc62d24ce71
Reviewed-on: https://code.wireshark.org/review/3798
Petri-Dish: Graham Bloice <>...

29659139 03/04/2014 09:27 AM Alexis La Goutte

Remove all $Id$ from top of file

(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <>

65db8287 12/03/2013 05:16 PM Jakub Zawadzki

When including <epan/prefs.h> don't force inclusion of <epan/uat.h>

svn path=/trunk/; revision=53769

db25270d 11/16/2013 09:55 PM Guy Harris

Move the epan/filesystem.c routines to wsutil; they're not specific to
packet dissection, they're specific to the entire Wireshark suite of
programs.

svn path=/trunk/; revision=53377

19f63eb2 10/18/2013 11:08 AM Bill Meier

Revert SVN #52650 as per discussion on wireshark-dev

svn path=/trunk/; revision=52671

26ad68d4 10/16/2013 04:02 PM Anders Broman

Prepend to lists rather than append as that's more efficient.

svn path=/trunk/; revision=52650

09c5152f 07/18/2013 12:28 AM Anders Broman

From Cal Turney:
Unrecognized preferences and color filters created in proprietary or older versions are discarded when saved.

If the user attempts to save the preferences or colorfilters file, a popup is displayed that warns that unrecognized prefs or color filters have been detected and will be discarded if the save operation is allowed to proceed. In the case of Preferences, the popup message includes the version at which the file was last saved. A "Continue without Saving" button is provided so that the user can save the profile under a different name....

e9d236ec 07/17/2013 01:52 AM Anders Broman

Backing out r50690 (exept simple_dialog)

struct FILE is different on windows vs *nix

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8942

svn path=/trunk/; revision=50691

e0341f77 07/17/2013 12:52 AM Anders Broman

From Cal Turney:
Unrecognized preferences and color filters created in proprietary or older versions are discarded when saved.

If the user attempts to save the preferences or colorfilters file, a popup is displayed that warns that unrecognized prefs or color filters have been detected and will be discarded if the save operation is allowed to proceed. In the case of Preferences, the popup message includes the version at which the file was last saved. A "Continue without Saving" button is provided so that the user can save the profile under a different name....

c2ced4a2 04/08/2013 10:48 PM Jeff Morriss

Don't try to open <home>/.wireshark on Windows: Wireshark hasn't written to
that directory since 2001 and reading from that directory was only left in for
backwards compatibility with versions prior to r4702. I think it's now safe
to remove that backwards compatibility....

2115cd76 02/28/2013 06:05 PM Bill Meier

color_edit_dlg update:
- Significantly simplify & rework code;
- Use GtkColorChooser instead of GtkColorSelection if GTK 3.4 or newer.
- Minor UI cleanup (default buttons & etc)
- Fix crash which occurred in the (existing) GTK3 related code.
- Fix some other relatively minor bugs (including some minor memory leaks);...

65331748 02/27/2013 11:15 AM Bill Meier

Use consistent indentation; Add editor modelines.

svn path=/trunk/; revision=47917

3551a86c 09/19/2012 09:29 PM Jeff Morriss

We always HAVE_CONFIG_H so don't bother checking whether we have it or not.

svn path=/trunk/; revision=45015

12a0aa48 09/03/2012 10:35 PM Jörg Mayer

- Replace packet_list_recreate_visible_rows > packet_list_recreate_visible_rows_list
Replace new_packet_list_ -> packet_list_

svn path=/trunk/; revision=44765

bf81b42e 06/28/2012 06:56 PM Jakub Zawadzki

Update Free Software Foundation address.

(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536

d7b2aad0 01/15/2012 08:07 PM Guy Harris

Move some headers for UI stuff, and the alert_box.c UI-specific file, to
the ui directory. (Perhaps some other files that would be used by all
flavors of Wireshark, for any GUI toolkit or for someting such as
ncurses, and not for any command-line tool such as TShark, should be...

706ea4db 08/17/2011 03:10 AM Anders Broman

Fix indentation.

svn path=/trunk/; revision=38573

6bdd7eed 07/01/2011 05:13 PM Stig Bjørlykke

Renamed "___tmp_color_filter___" to "___conversation_color_filter___"
in the coloring rule name to better describe where it comes from.

svn path=/trunk/; revision=37859

8443bbbf 06/28/2011 05:00 AM Stig Bjørlykke

Replace all strerror() with g_strerror().
Remove our local strerror implementation.
Mark strerror as locale unsafe API.

This fixes bug 5715.

svn path=/trunk/; revision=37812

1372515b 05/17/2011 06:18 PM Guy Harris

More eradication of old-style function definitions.

svn path=/trunk/; revision=37216

b6c370c9 04/25/2011 10:53 PM Guy Harris

Get rid of a cast that was causing alignment warnings and that was bogus
anyway (the second argument to g_slist_find_custom is a gconstpointer,
not a gpointer * or a gconstpointer *).

svn path=/trunk/; revision=36863

41c43385 03/08/2011 04:21 PM Chris Maynard

Display a console warning instead of a simple_dialog for invalid color filters.

svn path=/trunk/; revision=36173

a96e3dbe 03/08/2011 03:23 PM Stephen Fisher

A little more old packet list cleanup

svn path=/trunk/; revision=36172

307c0d70 03/07/2011 08:52 PM Sake Blok

Removal of the old packet-list in favor of the new packet list.
It compiles with "./configure without options" on my Mac. Let's see what the buildbots have to say about it :-)

svn path=/trunk/; revision=36161

2e4f755e 10/12/2010 03:26 PM Bill Meier

Define some vars & fcns as static;
Also: do some minor reformmating and cleanup of whitespace.

svn path=/trunk/; revision=34492

042b27ba 03/01/2010 07:26 PM Guy Harris

Squelch some compiler warnings.

svn path=/trunk/; revision=32079

2f199b9d 10/19/2009 10:21 AM Stig Bjørlykke

Made some functions static.

svn path=/trunk/; revision=30616

3ea94097 09/21/2009 02:48 PM Kovarththanan Rajaratnam

Store 'color_filter' as const in 'frame_data'

svn path=/trunk/; revision=30051

5c51aacb 09/06/2009 02:07 AM Kovarththanan Rajaratnam

Add NEW_PACKET_LIST guard to color_filters_colorize_packet()

svn path=/trunk/; revision=29729

94f28dd8 08/26/2009 03:27 PM Bill Meier

(FWIW) One step towards including stdio.h & stdlib.h only when req'd.

svn path=/trunk/; revision=29568

ca335d25 08/10/2009 04:52 PM Anders Broman

From Kovarththanan Rajaratnam:
- Compute and cache color/custom filters dynamically.
- Delay column construction.

svn path=/trunk/; revision=29370

edc8ae64 07/20/2009 02:21 AM Stephen Fisher

Introduce packet list coloring for the NEW_PACKET_LIST. One caveat: when
enabling/disabling the coloring of the packet list from the menus, the user
has to drag the mouse cursor over each displayed row to take away/add the
coloring. Dragging the scroll bar up or down will also take care of this as...

e6d0686f 06/30/2009 02:05 PM Stephen Fisher

Introduce experimental new feature: GTK2 tree view based packet list

To use the GTK2 based packet list, define NEW_PACKET_LIST when compiling.
To do this with gcc, set the environment variable CPPFLAGS to
"-DNEW_PACKET_LIST" and re-run configure.

Many features do not yet work. This work began with prototypes by Ulf...

a5cee04f 05/22/2008 11:46 AM Jeff Morriss

Move the file utility functions from wiretap to libwsutil so that
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354

a2b19b36 02/26/2008 07:24 PM Bill Meier

Fix another compile error ....

svn path=/trunk/; revision=24484

2389b572 02/26/2008 02:13 PM Jeff Morriss

get_datafile_path() and get_persconffile_path() return malloc'd memory,
free it when we're done with the file name.

svn path=/trunk/; revision=24478

a2d1e900 01/14/2008 11:40 AM Stig Bjørlykke

This patch adds support for configuration profiles, which can be used to
configure and use more than one set of preferences and configuration files.

This can be found in the "Configuration Profiles..." menu item from the Edit
menu, or by pressing Shift-Ctrl-A. It's also possible to start wireshark...

9a2d18d3 12/15/2007 06:38 PM Sake Blok

Changes the name of the menu item "View/Reset Coloring" to
"View/Reset Coloring 1-10" and adds sensitivity to it so that
it will be greyed out when none of the temporary color filters
are used.

(as per discussion on wireshark-dev some time ago)

svn path=/trunk/; revision=23879

f9ca3358 11/25/2007 10:55 AM Sake Blok

Make it possible to "move" a filter around the temporary coloring rules

svn path=/trunk/; revision=23585

61e7574a 11/25/2007 09:17 AM Sake Blok

Reset the temporary coloring filters to defaults instead of doing it
implicitly by calling "color_filters_init()". This should probably
fix the crashes experienced when pressing ctrl-space a couple of times

svn path=/trunk/; revision=23583

db2f6ce5 11/25/2007 07:36 AM Sake Blok

Fixes crashing when opening color filters and pressing OK
(introduced in SVN 23560)

svn path=/trunk/; revision=23582

9b6f8060 11/24/2007 06:38 AM Sake Blok

This patch adds (ten) temporary coloring rules which will only live until Wireshark is
quit. Temporary coloring filters can be set by:

- pressing <ctrl>-<digit> will create a conversation coloring filter based on the
addresses of the currently selected packet (order TCP/UDP/IP/Ethernet)...

508e2680 11/10/2007 10:18 AM Sake Blok

This patch makes it possible to disable individual coloring rules
without having to delete them. The patch has been tested on
Fedora-7 with GTK+ 1.2.10 and GTK+ 2.10.11.

Since I don't know how to use "strikethrough" in clists in GTK1
there is a little difference in how the disabled coloring rules...

0c3e8b7c 08/21/2007 05:15 PM Richard van der Hoff

From Florent DROUIN <>, bug 1518:

Fix for g_assert when clicking 'OK' on colour filters dialogue whilst
individual filter edit window is open.

svn path=/trunk/; revision=22572

ba962a91 11/06/2006 06:59 PM Ulf Lamping

fix 1203 as found by stephen fisher

svn path=/trunk/; revision=19839

ea6f7451 10/10/2006 04:07 AM Guy Harris

Fix some compiler warnings.

svn path=/trunk/; revision=19470

7a7b422f 10/03/2006 07:24 PM Ulf Lamping

fix the memory leak problem mentioned lately by adding and using color_filters_cleanup()

svn path=/trunk/; revision=19422

0da87716 10/03/2006 06:32 PM Ulf Lamping

changes of the coloring rules sometimes crashed as dissection keeps pointers to the color_filter for later reference -> simply deleting the filters leave the pointers invalid -> crash.

for now, don't delete the filters but keep them floating around in memory (leaking) -> at least better than crashing...

9e6c7b11 10/03/2006 02:39 PM Ulf Lamping

Implement a real "Cancel" button for the coloring rules dialog - this was a hard one! It seems to be working without bugs and as designed now.

As this was a huge internal change, new bugs are very probable - please report.

The implementation isn't still perfect, a new dialog internal list could possibly be removed again....

59d206d1 10/02/2006 07:01 PM Ulf Lamping

further code cleanup: don't use the term "marked" for the color filters, the right term is "selected". That caused me "concerns" wether the marked feature of the packet list was involved - which is actually not

svn path=/trunk/; revision=19399

b2c8fb8f 10/02/2006 05:55 PM Ulf Lamping

refactor apply_color_filter() as it was a bit confusing - it will also be a bit faster now -
and some other minor code cleanup

svn path=/trunk/; revision=19398

f0b33a47 05/22/2006 04:14 AM Ronnie Sahlberg

ethereal->wireshark updates

svn path=/trunk/; revision=18206

89f022b1 05/21/2006 01:12 AM Ronnie Sahlberg

name change

svn path=/trunk/; revision=18197

c3187174 11/06/2005 05:43 PM Ulf Lamping

replace a lot of file related calls by their GLib counterparts. This is necessary for the switch to GTK 2.6 (at least on WIN32).

to do this, I've added file_util.h to wiretap (would file_compat.h be a better name?), and provide compat_macros like eth_open() instead of open(). While at it, move other file related things there, like #include <io.h>, definition of O_BINARY and alike, so it's all in one place....

956eee94 08/14/2005 07:25 PM Jörg Mayer

Some 'no previous declararion' warning fixes

svn path=/trunk/; revision=15355

4e1f4b18 08/05/2005 04:59 PM Jörg Mayer

More char -> const char warning fixes.
Removed (very few) casts that only change the warning message
but don't remove it (with gcc-4).

svn path=/trunk/; revision=15227

729749c5 03/26/2005 09:19 PM Ulf Lamping

add a new checkitem "Colorize Packet List" into the View menu

keep it's setting in the recent file

svn path=/trunk/; revision=13929

2b8ac21d 03/26/2005 06:32 AM Ulf Lamping

move some color_filter related things from file.c to color_filters.c

svn path=/trunk/; revision=13920

f3d2a926 03/25/2005 10:27 PM Guy Harris

There's no need to create a directory just because you're about to
remove a file in it - the directory presumably exists already, if you're
about to remove a file in it.

svn path=/trunk/; revision=13914

ccff84db 03/25/2005 08:09 PM Ulf Lamping

code cleanup: use common prefix for all functions in color_filters.h

svn path=/trunk/; revision=13910

008d4b81 03/25/2005 05:52 PM Ulf Lamping

code cleanup: the term filter_list was used with different meanings throughout the code, and the filter_list of the color_filters is "global".

use appropriate prefixes to avoid confusion and bugs

svn path=/trunk/; revision=13905

f3294ee4 02/12/2005 07:10 PM Lars Roland

change nmake makefiles in /trunk and /trunk/epan so that
object code for libethereal.dll isn't generated by the
makefile in /trunk.

Having no code in /trunk linked into libethereal.dll
anymore, the definition of the macro NEED_VAR_IMPORT
can be moved from various source files in /trunk to /trunk/Makefile.nmake ....

1d182e4f 12/30/2004 07:29 PM Guy Harris

"get_persconffile_path()" doesn't return a "const char *", it just
returns a "char *", so don't assign its return value to a "const char *".

svn path=/trunk/; revision=12882

6f0ad62d 09/21/2004 01:17 AM Ulf Lamping

fixed some comment typos

svn path=/trunk/; revision=12057

d3e6d377 07/25/2004 05:55 AM Guy Harris

From Lars Roland: NEED_VAR_IMPORT has to be defined so that variables
are imported correctly from libethereal.dll when compiling with MSVC.

svn path=/trunk/; revision=11516

13e4c5b1 07/23/2004 10:08 PM Guy Harris

Rename "create_color()" to "initialize_color()", as that reflects a bit
better what it actually does.

svn path=/trunk/; revision=11502

e046206f 07/23/2004 09:32 PM Guy Harris

Add some comments from Gerald's Windows version of color_filters.c.

svn path=/trunk/; revision=11501

b67a0f92 07/23/2004 09:29 PM Guy Harris

Move color_filters.c and color_filters.h up to the top-level directory,
as they're now (theoretically) toolkit-independent (modulo changes that
might be required to the code to update filter lists when a new filter
is read in).

svn path=/trunk/; revision=11500