The data contained in this repository can be downloaded to your computer using one of several clients.
Please see the documentation of your version control software client for more information.

Please select the desired protocol below to get the URL.

This URL has Read-Only access.

Statistics
| Branch: | Revision:

main_repo / summary.c @ master

History | View | Annotate | Download (6.69 KB)

# Date Author Comment
97546165 08/24/2014 04:04 AM Graham Bloice

Modify includes of config.h so that out-of-tree builds, i.e. CMake
don't pick up the in-tree copy.

Change-Id: I7ec473876cdba1a025c52362d7f6adc62d24ce71
Reviewed-on: https://code.wireshark.org/review/3798
Petri-Dish: Graham Bloice <>...

df583372 06/29/2014 09:36 PM Guy Harris

Move capture_ui_utils.[ch] to libui.

Change-Id: Id0f3d4d60a1acc7aa64fd3737b8f16df5bca4e5a
Reviewed-on: https://code.wireshark.org/review/2708
Reviewed-by: Guy Harris <>

3aee9170 05/17/2014 08:41 AM Peter Wu

wiretap: remove unused code, drop number_of_interfaces

While investigating an ASAN issue (fixed in
commit dcdd076ab0965c346efe90051678ba790eaf7a02), I got greatly confused
by three different types having the same "interface_data" field name:

  • pcapng_t *pn stores an array of interface_data_t objects....
a1b1c8be 05/09/2014 01:21 AM Guy Harris

Revert "Refactor Wiretap"

This reverts commit 1abeb277f5e6bd27fbaebfecc8184e37ba9d008a.

This isn't building, and looks as if it requires significant work to fix.

Change-Id: I622b1bb243e353e874883a302ab419532b7601f2
Reviewed-on: https://code.wireshark.org/review/1568...

1abeb277 05/08/2014 11:04 PM Michael Mann

Refactor Wiretap

Start of refactoring Wiretap and breaking structures down into "generally useful fields for dissection" and "capture specific". Since this in intended as a "base" for Wiretap and Filetap, the "wft" prefix is used for "common" functionality....

29659139 03/04/2014 09:27 AM Alexis La Goutte

Remove all $Id$ from top of file

(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <>

3551a86c 09/19/2012 09:29 PM Jeff Morriss

We always HAVE_CONFIG_H so don't bother checking whether we have it or not.

svn path=/trunk/; revision=45015

bf81b42e 06/28/2012 06:56 PM Jakub Zawadzki

Update Free Software Foundation address.

(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536

d1128f64 06/15/2012 07:54 PM Guy Harris

For a capture file, keep an array of all encapsulation types seen.

Show all of them in the summary dialog; we will be using it in the
future to figure out what capture file formats we can write to (just
because a capture file format supports per-packet encapsulations, that...

ee578475 05/27/2012 09:23 PM Guy Harris

That doesn't work correctly if we read in a file with no interface
information, as it'll fill in whatever stuff happens to be in the
capture info. We should somehow figure uot whether this is a capture we
just did (note: cf->is_tempfile does NOT necessarily tell us that, as...

88fb10b8 05/27/2012 09:17 PM Guy Harris

Correctly implement what was my intent when removing the HAVE_LIBPCAP
stuff - arrange that the interface summary list is set, if we've read a
capture file that has interface information, regardless of whether we
have libpcap/WinPcap or not.

That means that summary_fill_in() should fill in the interface...

53375198 05/27/2012 08:31 PM Guy Harris

Don't use pcap LINKTYPE_ values in the iface_options structure, use
Wiretap encapsulation values; rename the field in question encap_type to
emphasize that. (Code that looks at that field already assumes it's a
Wiretap encapsulation value.)

For live captures, map the LINKTYPE_ value to a Wiretap encapsulation...

bd7c59b2 05/27/2012 07:32 PM Guy Harris

Clean up indentation (use spaces, not tabs).

svn path=/trunk/; revision=42868

a4bbd979 05/24/2012 02:59 PM Jeff Morriss

Use cf_update_capture_comment() to save the capture comment (instead of
summary_update_comment() which is no longer necessary).
cf_update_capture_comment() has the advantage that it doesn't mark the file
as unsaved unless the comment actually changed.

svn path=/trunk/; revision=42832

cf6d9841 05/24/2012 01:05 AM Guy Harris

Keep track, in Wiretap, of whether the file is compressed, and provide
an API to fetch that.

When doing "Save" on a compressed file, write it out compressed.

In the Statistics -> Summary dialog and in capinfos, report whether the
file is gzip-compressed....

f21d6f1d 05/05/2012 05:00 PM Bill Meier

Actually remove #include <sys/types.h> ....

svn path=/trunk/; revision=42444

a7034506 05/05/2012 04:51 PM Bill Meier

AFAICT '#include sys/types.h' is not needed for these files.

svn path=/trunk/; revision=42443

f7980fd0 03/20/2012 10:39 PM Chris Maynard

Delete a duplicate line of code. Fixes Coverity CID 1393: UNUSED VALUE.

svn path=/trunk/; revision=41700

fb0fec7c 03/15/2012 10:33 AM Anders Broman

If we have one ISB, display the droped count from it.

svn path=/trunk/; revision=41561

971cb848 03/04/2012 02:01 PM Anders Broman

if_filter isn't a string per se,The first byte of the Option Data keeps a code of the filter used

svn path=/trunk/; revision=41339

d24fad63 02/29/2012 11:51 AM Anders Broman

- Add a LED in the statusbar to indicate that capture comments exists,
clickable to open an edit window.
- Add checks for NULL pointers.

Help with a different color LED possibly with Jeff's (c) in it apreceated.
Should the LED be placed elsewhere or the whole thing done differently?...

38c69c84 02/26/2012 12:04 PM Anders Broman

Make it possible to edit capture comments

svn path=/trunk/; revision=41193

30b86b78 02/26/2012 03:02 AM Guy Harris

Suppress invalid or non-meaningful statistics - for example, without
time stamps on all packets in a set, you can't determine the start and
end time of the packets in the set (even one timestampless packet throws
the determination off - was that packet before the first time-stamped or...

71947665 02/24/2012 08:05 AM Michael Tüxen

From Irene Ruengeler: Fix a bug where the interface
names are not shown during capturing.

svn path=/trunk/; revision=41175

b5a2ba98 02/23/2012 04:29 PM Anders Broman

Add SHB info to Summary

svn path=/trunk/; revision=41167

dddfe189 02/23/2012 02:14 PM Michael Tüxen

Fix the handling of snaplen.
While there fix some whitespace issues.

svn path=/trunk/; revision=41164

286f3425 02/23/2012 10:40 AM Anders Broman

Have the used interfaces show up if number of interfaces > 0.
(pcapng file).

svn path=/trunk/; revision=41163

b30c60d2 07/15/2011 04:45 PM Michael Tüxen

Don't show interface info when loading a capture file.

svn path=/trunk/; revision=38051

cb90aa79 07/05/2011 04:34 PM Michael Tüxen

Add initial support for multiple interfaces. More to come after
the capture options dialog box supports also multiple interfaces.

This patch has been developed by Irene Ruengeler.

svn path=/trunk/; revision=37904

421dafd2 06/26/2011 08:09 PM Michael Tüxen

Get rid of old non-interface specific settings which are now interface
specifc. This finalizes the change of the infrastructure.
This patch is based on work by Irene Ruengeler.

svn path=/trunk/; revision=37794

c9b9dd69 04/26/2011 10:54 PM Guy Harris

Create a new frame_data_sequence data type; it represents a dense
sequence of frame_data structures, indexed by the frame number. Extract
the relevant bits of the capture_file data structure and move them to
the frame_data_sequence, and move the relevant code from cfile.c and...

71b31d92 04/25/2011 03:01 PM Guy Harris

Store the frame_data structures in a tree, rather than a linked list.
This lets us get rid of the per-frame_data-structure prev and next
pointers, saving memory (at least according to Activity Monitor's report
of the virtual address space size on my Snow Leopard machine, it's a...

678be392 04/25/2011 01:33 AM Guy Harris

Make the packet count an unsigned value, as frame numbers are unsigned.

Make the loops that scan through all the packets do so by frame number,
to abstract away the "next" and "previous" pointers in the frame_data
structure. Add a routine to cfile.c to map frame numbers to frame_data...

ef92b4ec 12/17/2009 07:05 AM Stig Bjørlykke

Added "Ignore Packet" menu items to the main menu.
Show ignored packages in the summary dialog.

svn path=/trunk/; revision=31289

7ca137e2 09/21/2009 02:09 PM Kovarththanan Rajaratnam

Rename capture_file.plist to capture_file.plist_start to make it consistent with capture_file.plist_end

svn path=/trunk/; revision=30047

c99312da 10/14/2008 06:55 PM Gerald Combs

Use a more accurate variable name for the wiretap file type. Add the file
encapsulation to the summary display.

svn path=/trunk/; revision=26459

6e39bc94 11/27/2007 08:09 PM Stig Bjørlykke

Summary enhancements:
- Added traffic statistics for marked packages.
- Do not show Displayed column unless using it.
- Removed Marked packets line, as this info is in the marked packets column.

Will add documentation changes if keeping this feature.

svn path=/trunk/; revision=23633

482e3f78 11/27/2007 08:04 PM Stig Bjørlykke

Fixed a bug when adjusting summary marked start time.

svn path=/trunk/; revision=23632

92802883 08/29/2007 08:24 PM Gerald Combs

Change the "--enable-setuid-install" option to install dumpcap and TShark
setuid instead of Wireshark. Remove the "DANGEROUS" notices, but leave it
disabled by default. Whine if the user runs Wireshark or TShark as root.
Add a preference to disable the whining. Add a "setuid-root" script that...

8043464c 08/22/2007 02:56 PM Jeff Morriss

gcc 4 doesn't like my macro for getting the interface description: it says there's an invalid lvalue in it. I don't see what's wrong with it, but replace the macro with a function. Also: don't include the .xpm files in gtk/main.c if we're building without PCAP (as they're not used in that configuration)....

2f77efce 08/22/2007 12:30 PM Jeff Morriss

Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1757 :

Try to call get_interface_descriptive_name() as little as possible (storing
the result in capture_opts) to avoid a performance hit during live capture
(especially if you have lots of interfaces) and to avoid leaking memory....

89f022b1 05/21/2006 01:12 AM Ronnie Sahlberg

name change

svn path=/trunk/; revision=18197

6f43fbb2 08/24/2005 05:31 PM Ulf Lamping

EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!

I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ......

e67b202e 08/18/2005 09:17 PM Guy Harris

Have "f_datalen" keep track of the number of bytes of uncompressed file
data, so that "f_len" still keeps the size of the underlying file (which
is necessary in order to make the progress bar when files are being read
work correctly).

svn path=/trunk/; revision=15415

3a63719e 02/06/2005 04:20 PM Ulf Lamping

another two steps towards privilege seperation:

move another two capture related fields (iface and cfilter) from cfile to capture_opts

also move the handling of capture related command line options from main.c to capture.c, that way a future privilege seperated capture program can use the same code to parse it's command line than Ethereal....

69e94faf 02/04/2005 02:29 PM Ulf Lamping

remove #include "globals.h" from summary.c, as it's a bad idea for multiple capture files.
If a summary user would like to get a summary, it should know the file of which it needs the summary.

svn path=/trunk/; revision=13291

8a8b8834 07/17/2004 08:24 PM Guy Harris

Set the svn:eol-style property on all text files to "native", so that
they have LF at the end of the line on UN*X and CR/LF on Windows;
hopefully this means that if a CR/LF version is checked in on Windows,
the CRs will be stripped so that they show up only when checked out on...

71034c5a 09/02/2003 06:10 PM Guy Harris

From Jean-Michel Fayard: show in Tools:Summary window statistics about
packets that passed the current display filter, as well as about the
entire capture.

Document the Tools:Summary item in the man page.

Update Gerald's e-mail address.

svn path=/trunk/; revision=8344

89a4acb4 02/08/2002 05:07 AM Guy Harris

Have Wiretap set the snapshot length to 0 if it can't be derived from
reading the capture file. Have callers of "wtap_snapshot_length()"
treat a value of 0 as "unknown", and default to WTAP_MAX_PACKET_SIZE (so
that, when writing a capture file in a format that does store the...

ee5ca25d 01/21/2002 02:37 AM Guy Harris

Include files from the "epan" directory and subdirectories thereof with
"epan/..." pathnames, so as to avoid collisions with header files in any
of the directories in which we look (e.g., "proto.h", as some other
package has its own "proto.h" file which it installs in the top-level...

bf0a3a32 02/11/2001 04:28 AM Guy Harris

In Ethereal, attempt to get the packet statistics from libpcap when
capturing; if we succeed, display the packet drops count as the "Drops"
value in the status line and as the "Dropped packets" statistics in the
summary dialog box, otherwise don't display it at all....

05984d23 08/21/2000 02:20 PM Laurent Deniel

Add the number of marked packets in the summary window.

svn path=/trunk/; revision=2323

7fbf320b 06/27/2000 12:36 AM Guy Harris

Patch from Ben Fowler to rename the global variable "cf" to "cfile", to
make it easier to use grep to find all references to it without getting
a lot of false hits and to check, after allocating the memory chunk for
"frame_data" structures, that the allocation succeeded....

b218a8f5 04/13/2000 04:39 PM Gilbert Ramirez

Consolidate flags in struct frame_data, and add "visited" flag. Use
it in SOCKS dissector.

(Okay, how many times am I going to modify packet.h today, forcing you
to re-compile everything? :-)

svn path=/trunk/; revision=1850

c3e2626f 12/29/1999 04:30 PM Guy Harris

If there aren't any packets in the capture (which could be the case if,
for example, you're doing a live capture with "Update list of packets in
real time" and none have arrived yet, or if you've read in a capture
file where there aren't actually any packets), don't look for the start...

71b7cd50 12/09/1999 11:21 PM Gilbert Ramirez

Move GTK code out of summary.c and into gtk/summary_dlg.c
summary.c now provides a struct of info (see summary.h)

Changed the name of the summary dialogue callback (hence the change
in menu.c), and added a close button to the dialogue.

Moved #include <gtk/gtk.h> out of print.c and into prefs.h where it...

a34c9711 12/04/1999 03:59 AM Guy Harris

Now that "wtap_file_type_string()" takes a file type rather than a "wtap
*" as an argument, there's no need to save the file type string in a
"capture_file" structure - we save the file type, and can use that when
generating the summary display.

svn path=/trunk/; revision=1202

3b9013d3 10/11/1999 02:39 AM Guy Harris

When a new display filter is to be applied, don't set "cf.dfilter" or
"cf.dfcode" if the new filter doesn't compile, because the filter
currently in effect will be the one that was last applied - just free up
the text of the new filter, and whatever memory was allocated for the...

3c49e45c 09/08/1999 10:42 PM Gilbert Ramirez

More shuffling of GTK-related files to gtk subdirectory.

svn path=/trunk/; revision=635

65c3e8d9 08/31/1999 11:04 PM Gilbert Ramirez

Moved GTK-dependent routines for file dialogues, print dialogues, print
preferences, and menus to gtk subdirectory.

svn path=/trunk/; revision=623

cb1e32da 08/24/1999 01:26 PM Gilbert Ramirez

Removed unnecessary #include "etypes.h" lines.

svn path=/trunk/; revision=565

ab649039 08/13/1999 07:47 PM Gilbert Ramirez

Moved global memory alloction used in display filters (which was stored
in dfilter-grammar.y) to a new struct dfilter. Display filters now have
their own struct, rather than simply being GNode's. This allows multiple
display filters to exist at once, aiding John McDermott in his...

86a8ad1d 08/10/1999 12:13 AM Guy Harris

Building a GList by adding elements to the end with "g_list_append()" is
N^2 in the ultimate size of the list (as "g_list_append()" is linear in
the size of the list, at least when used in the way the GLib
documentation says to use it); instead, maintain our own linked list of...

79c22234 08/01/1999 10:04 PM Guy Harris

Check in Olivier Abad's patch to add dissectors for LAP-B and X.25, and
wiretap support for RADCOM Ltd.'s WAN/LAN analyzers (see

http://www.radcom-inc.com/

). Note: as I remember, IEEE 802.2/ISO 8022 LLC has somewhat of an SDLC
flavor to it, just as I think LAP, LAPB, LAPD, and so on do, so we may...

57e49071 07/12/1999 11:08 PM Gilbert Ramirez

Since ethereal is now dependent on GTK+-1.2.x (because of proto_tree and
display filter code, which uses features in GLIB-1.2.x), I removed
the vestigial code supporting old 1.0.x and 1.1.x GTK+ versions.

svn path=/trunk/; revision=360

601c52f0 07/12/1999 10:53 PM Gilbert Ramirez

Added support for compiling on win32 with Visual C and 'nmake'. It compiles,
but does not link. Perhaps someone who understands the MS tools can help
out. I made it link a few months ago, but with different version of glib/gtk+.
I can't remember how I made it link....

5a7e28ca 07/09/1999 12:18 AM Gilbert Ramirez

Added the ability to create a read-only ethereal, i.e., one that
doesn't link with libpcap, so no packet captures can be made. The
"--disable-pcap" option has been added to the configure script. Docs
have been updated. And the string buffer size in the simple_dialog()...

07f42b5b 07/07/1999 06:52 PM Gilbert Ramirez

Created a new protocol tree implementation and a new display filter
mechanism that is built into ethereal. Wiretap is now used to read all
file formats. Libpcap is used only for capturing.

svn path=/trunk/; revision=342

057f3639 07/04/1999 02:41 AM Guy Harris

In GTK+ 1.0[.x], "gtk_window_set_position()" was called
"gtk_window_position()", so use "gtk_window_position()" if we're using
GTK+ 1.0[.x].

svn path=/trunk/; revision=336

7ea29fb8 06/22/1999 06:02 PM Gilbert Ramirez

Added Aaron Hillegass' summary dialogue. We're ignoring the problem with
NetMon statistic packets for now. We might fix that problem with wiretap,
either filtering out those packets, and/or providing the summary
information through a new wiretap API.

svn path=/trunk/; revision=326