The data contained in this repository can be downloaded to your computer using one of several clients.
Please see the documentation of your version control software client for more information.

Please select the desired protocol below to get the URL.

This URL has Read-Only access.

Statistics
| Branch: | Revision:

main_repo / test / simple / test-stream2-unpipe-leak.js @ 6f043940

History | View | Annotate | Download (2.44 KB)

# Date Author Comment
cd2b9f54 03/10/2013 02:04 PM isaacs

stream: Avoid nextTick warning filling read buffer

In the function that pre-emptively fills the Readable queue, it relies
on a recursion through:

stream.push(chunk) ->
maybeReadMore(stream, state) ->
if (not reading more and < hwm) stream.read(0) ->
stream._read() ->...
cd68d86c 03/05/2013 05:27 PM isaacs

stream: Remove output function from _transform

Just use stream.push(outputChunk) instead.
119cbf48 03/04/2013 10:38 AM isaacs

stream: Don't require read(0) to emit 'readable' event

When a readable listener is added, call read(0) so that data will flow in, up to
the high water mark.

Otherwise, it's somewhat confusing that you have to listen for readable,
and ALSO call read() (when it will certainly return null) just to get some...
88644eaa 02/28/2013 08:38 PM isaacs

stream: There is no _read cb, there is only push

This makes it so that `stream.push(chunk)` is the only way to signal the
end of reading, removing the confusing disparity between the
callback-style _read method, and the fact that most real-world streams
do not have a 1:1 corollation between the "please give me data" event,...
5daa701a 12/26/2012 05:56 PM Andreas Madsen

stream: fix event handler leak in readstream pipe and unpipe

After a stream was unpiped there would stil be residual event handlers